New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

digs into pageable response for snapshot lists #128

Merged
merged 2 commits into from Jun 28, 2015

Conversation

Projects
None yet
4 participants
@sonnysideup
Contributor

sonnysideup commented Apr 13, 2015

change required by aws-sdk v2 gem

digs into pageable response for snapshot lists
change required by aws-sdk v2 gem
only find ebs snapshots that have completed
because attempting to attach a snapshot in a "pending" state is silly
@sonnysideup

This comment has been minimized.

Show comment
Hide comment
@sonnysideup

sonnysideup Apr 14, 2015

Contributor

Also added a check for the snapshot state because attempting to create an EBS volume from a snapshot in a "pending" state results in an error.

Contributor

sonnysideup commented Apr 14, 2015

Also added a check for the snapshot state because attempting to create an EBS volume from a snapshot in a "pending" state results in an error.

@scalp42

This comment has been minimized.

Show comment
Hide comment
@scalp42

scalp42 Apr 17, 2015

Contributor

LGTM

Contributor

scalp42 commented Apr 17, 2015

LGTM

@sonnysideup

This comment has been minimized.

Show comment
Hide comment
@sonnysideup

sonnysideup Apr 27, 2015

Contributor

How do we get this merged into master?

Contributor

sonnysideup commented Apr 27, 2015

How do we get this merged into master?

@scalp42

This comment has been minimized.

Show comment
Hide comment
@scalp42

scalp42 Apr 28, 2015

Contributor

Need to wait for a guy from Opscode to look at it @drywheat 🔮

Contributor

scalp42 commented Apr 28, 2015

Need to wait for a guy from Opscode to look at it @drywheat 🔮

@miketheman miketheman added ebs and removed ebs labels Jun 13, 2015

@miketheman miketheman added the ebs label Jun 28, 2015

@miketheman miketheman added this to the 2.7.2 milestone Jun 28, 2015

miketheman added a commit that referenced this pull request Jun 28, 2015

Merge pull request #128 from orgsync-cookbooks/fix-ebs-vol-creation
digs into pageable response for snapshot lists

@miketheman miketheman merged commit afa451d into chef-cookbooks:master Jun 28, 2015

@miketheman

This comment has been minimized.

Show comment
Hide comment
@miketheman

miketheman Jun 28, 2015

Collaborator

Thanks!

Collaborator

miketheman commented Jun 28, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment