Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elastic lb provider fix - does not run deregister, always tries to register #133

Merged

Conversation

@purgatorio
Copy link
Contributor

purgatorio commented Apr 16, 2015

See issue: #132

This allows the deregister action to actually run and prevents the register action from running if the node is currently in the ELB.

Damian Pantano added 2 commits Apr 16, 2015
target_lb[:instances] returns a list of nodes in the ELB. This needs to use
detect for iteration so that it can discover the instance_id and determine
whether or not the instance is actually inside the ELB. Without this fix,
the current behavior has the deregister action never running and the register
action always running.
@DrMerlin

This comment has been minimized.

Copy link

DrMerlin commented Apr 16, 2015

+1

It looks good to me.

@scalp42

This comment has been minimized.

Copy link
Contributor

scalp42 commented Apr 17, 2015

LGTM

@miketheman

This comment has been minimized.

Copy link
Contributor

miketheman commented Jun 10, 2015

👍
@someara bump?

@miketheman miketheman added the elb label Jun 13, 2015
@miketheman miketheman added the bug label Jun 28, 2015
@miketheman miketheman modified the milestone: 2.7.2 Jun 28, 2015
miketheman added a commit that referenced this pull request Jun 28, 2015
Elastic lb provider fix - does not run deregister, always tries to register
@miketheman miketheman merged commit f125c2f into chef-cookbooks:master Jun 28, 2015
@miketheman

This comment has been minimized.

Copy link
Contributor

miketheman commented Jun 28, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.