Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to secondary_ip #192

Merged
merged 9 commits into from Jan 21, 2016

Conversation

Projects
None yet
3 participants
@Scythril
Copy link
Contributor

commented Jan 18, 2016

To resolve issue #137

This feature didn't work at all because one of the state_attrs parameters in the resource was incorrectly named (looks like a missed rename).

This features also seems to have been written specifically for Linux, but I've expanded it to be more platform-agnostic. It now pulls the default interface from node[:network]['default_interface'] instead of assuming eth0 if not provided, and also allows one to specify the IP to add (was just adding a random IP previously, which is still allowed if not provided).

I also updated the readme since it wasn't added when the original feature went in.

@chef-supermarket

This comment has been minimized.

Copy link

commented Jan 20, 2016

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.

Non-GitHub Verified Committers

There are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute.

Please sign the CLA here.

@Scythril Scythril force-pushed the Scythril:secondary_ip_windows_fix branch from 5a91800 to 710e20f Jan 20, 2016

@chef-supermarket

This comment has been minimized.

Copy link

commented Jan 20, 2016

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

@tas50 tas50 merged commit 63984d8 into chef-cookbooks:master Jan 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tas50

This comment has been minimized.

Copy link
Member

commented Jan 21, 2016

Nice changes. Thanks for putting together the documentation so others can easily use this going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.