New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support XFS as ebs_raid filesystem. Tweak README. #63

Merged
merged 4 commits into from Mar 11, 2016

Conversation

Projects
None yet
8 participants
@bazbremner
Contributor

bazbremner commented Apr 10, 2014

This could be generalised to a single

mkfs -t #{filesystem} #{md_device}

but this approach ensures xfs tools are available if required.

bazbremner added some commits Apr 10, 2014

Support XFS as ebs_raid filesystem. Tweak README.
This could be generalised to a single

    mkfs -t #{filesystem} #{md_device}

but this approach ensures xfs tools are available if required.
@chef-supermarket

This comment has been minimized.

chef-supermarket commented Jul 11, 2014

Hi. Your friendly Curry bot here. Just letting you know that there are commit authors in this Pull Request who appear to not have signed a Chef CLA.

The following GitHub users do not appear to have signed a CLA:

Please sign the CLA here.

@gswallow

This comment has been minimized.

gswallow commented on bb899e2 Aug 20, 2014

+1.

@gswallow

This comment has been minimized.

gswallow commented on providers/ebs_raid.rb in bb899e2 Aug 20, 2014

mke2fs -t #{filesystem} -E lazy_itable_init=1 -O uninit_bg -F #{md_device} is much faster.

@cwebberOps

This comment has been minimized.

Contributor

cwebberOps commented Oct 22, 2014

So testing against ubuntu-1204, this doesnt actually work. The chef run executes successfully but it doesnt actually properly lay down the filesystem


  * ruby_block[find md device in db_ebs_raid] action run       [2014-10-22T21:53:02+00:00] INFO: Processing ruby_block[find md device in db_ebs_raid] action run (/tmp/kitchen/cache/cookbooks/aws/providers/ebs_raid.rb line 271)
       [2014-10-22T21:53:02+00:00] INFO: Already mounted: /aws_raid
       [2014-10-22T21:53:02+00:00] INFO: Found /dev/md0
       mount: wrong fs type, bad option, bad superblock on /dev/md0,
       missing codepage or helper program, or other error
       In some cases useful info is found in syslog - try
       dmesg | tail  or so

       [2014-10-22T21:53:03+00:00] INFO: ruby_block[find md device in db_ebs_raid] called
@bazbremner

This comment has been minimized.

Contributor

bazbremner commented Oct 23, 2014

@cwebberOps Hrm. It's been 6 months since I looked at this code and I'm not using that particular setup on AWS either. I'm pretty sure it was working and we were running it in production, but I can only assume something else was at play.

I can't guarantee when I'll get the time to look at this, but I'll have a look when I can.

@cwebberOps

This comment has been minimized.

Contributor

cwebberOps commented Oct 24, 2014

@bazbremner no worries. I totally understand.

@@ -390,9 +390,12 @@ def create_raid_disks(mount_point, mount_point_owner, mount_point_group, mount_p
case filesystem
when "ext4"
system("mke2fs -t #{filesystem} -F #{md_device}")
when "xfs"
run_context.include_recipe 'xfs'
system("mkfs -t #{filesystem} #{md_device}")

This comment has been minimized.

@josegonzalez

josegonzalez Mar 4, 2015

mkfs.xfs #{md_device} is how I normally setup the FS, so I'll test this with my change and resubmit the PR assuming everything works.

@@ -6,3 +6,5 @@
long_description IO.read(File.join(File.dirname(__FILE__), 'README.md'))
version "2.1.2"
recipe "aws", "Installs the right_aws gem during compile time"
depends "xfs"

This comment has been minimized.

@tas50

tas50 Jan 26, 2016

Member

Since the xfs cookbook only installs xfsdump we can remove this and leave it up to the user to have a system capable of formatting and XFS volume

@iennae iennae referenced this pull request Mar 11, 2016

Merged

@bazbremner add xfs raid #217

@tas50 tas50 merged commit da0347b into chef-cookbooks:master Mar 11, 2016

1 check failed

continuous-integration/travis-ci/push The Travis CI build failed
Details
@iennae

This comment has been minimized.

Contributor

iennae commented Mar 11, 2016

@bazbremner Thank you so much for your contribution. Apologies for the delay in merging. As we've grown the cookbook team we are working to have a much quicker turn around on these kind of things.

@bazbremner

This comment has been minimized.

Contributor

bazbremner commented Mar 11, 2016

@iennae no problems - I've also not touched any cookbooks for a while either, such is life. Thanks for merging it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment