New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README with volume_type for gp2, fix minor text items in CHANGELOG #74

Merged
merged 1 commit into from Oct 22, 2014

Conversation

Projects
None yet
5 participants
@drewrothstein
Contributor

drewrothstein commented Jun 24, 2014

The "gp2" support is done here: #72

@mreeves1

This comment has been minimized.

Show comment
Hide comment
@mreeves1

mreeves1 Jul 2, 2014

👍
Might be worthwhile to log a warning that the piops value is ignored if the volume type is not io1.

mreeves1 commented Jul 2, 2014

👍
Might be worthwhile to log a warning that the piops value is ignored if the volume type is not io1.

@drewrothstein

This comment has been minimized.

Show comment
Hide comment
@drewrothstein

drewrothstein Jul 5, 2014

Contributor

@mreeves1, I think this already exists: https://github.com/opscode-cookbooks/aws/blob/master/providers/ebs_volume.rb#L164

This is just a README update.

Contributor

drewrothstein commented Jul 5, 2014

@mreeves1, I think this already exists: https://github.com/opscode-cookbooks/aws/blob/master/providers/ebs_volume.rb#L164

This is just a README update.

@chef-supermarket

This comment has been minimized.

Show comment
Hide comment
@chef-supermarket

chef-supermarket Jul 11, 2014

Hi. Your friendly Curry bot here. Just letting you know that there are commit authors in this Pull Request who appear to not have signed a Chef CLA.

The following GitHub users do not appear to have signed a CLA:

Please sign the CLA here.

chef-supermarket commented Jul 11, 2014

Hi. Your friendly Curry bot here. Just letting you know that there are commit authors in this Pull Request who appear to not have signed a Chef CLA.

The following GitHub users do not appear to have signed a CLA:

Please sign the CLA here.

@drewrothstein

This comment has been minimized.

Show comment
Hide comment
@drewrothstein

drewrothstein Jul 11, 2014

Contributor

CLA signed.
I signed it prior to launching your supermarket site, I guess it didn't carry over.

Contributor

drewrothstein commented Jul 11, 2014

CLA signed.
I signed it prior to launching your supermarket site, I guess it didn't carry over.

@cwebberOps

This comment has been minimized.

Show comment
Hide comment
@cwebberOps

cwebberOps Jul 12, 2014

Contributor

Sadly we weren't able to port it over 😞

http://www.getchef.com/blog/2014/06/23/changes-to-the-contributor-license-agreement-process/ has a bit more of the details on the whole thing, but basically the data wasn't stored in a way that we could associate it with user accounts in a sane way.

Thanks for re-signing! You rock!

Contributor

cwebberOps commented Jul 12, 2014

Sadly we weren't able to port it over 😞

http://www.getchef.com/blog/2014/06/23/changes-to-the-contributor-license-agreement-process/ has a bit more of the details on the whole thing, but basically the data wasn't stored in a way that we could associate it with user accounts in a sane way.

Thanks for re-signing! You rock!

@billmoritz

This comment has been minimized.

Show comment
Hide comment
@billmoritz

billmoritz Aug 20, 2014

Anything holding back this pull request?

billmoritz commented Aug 20, 2014

Anything holding back this pull request?

cwebberOps added a commit that referenced this pull request Oct 22, 2014

Merge pull request #74 from drewrothstein/master
update README with volume_type for gp2, fix minor text items in CHANGELOG

@cwebberOps cwebberOps merged commit 2ecb615 into chef-cookbooks:master Oct 22, 2014

@cwebberOps

This comment has been minimized.

Show comment
Hide comment
@cwebberOps

cwebberOps Oct 22, 2014

Contributor

Thank you for your contribution!

Contributor

cwebberOps commented Oct 22, 2014

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment