New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When configure_from_channel limit remote_file backups to 1. #106

Merged
merged 1 commit into from Jun 8, 2016

Conversation

Projects
None yet
6 participants
@stephenlauck
Contributor

stephenlauck commented May 13, 2016

No description provided.

@schisamo

This comment has been minimized.

Show comment
Hide comment
@schisamo

schisamo May 13, 2016

Contributor

/cc @chef-cookbooks/engineering-services

Contributor

schisamo commented May 13, 2016

/cc @chef-cookbooks/engineering-services

@yzl

This comment has been minimized.

Show comment
Hide comment
@yzl

yzl commented May 13, 2016

👍

@schisamo

This comment has been minimized.

Show comment
Hide comment
@schisamo

schisamo May 13, 2016

Contributor

@stephenlauck I opened an issue for the why behind this fix: #107

Do you mind amending your commit message and adding a Fixes #107 so the fix and issue are linked?

Contributor

schisamo commented May 13, 2016

@stephenlauck I opened an issue for the why behind this fix: #107

Do you mind amending your commit message and adding a Fixes #107 so the fix and issue are linked?

@sersut

This comment has been minimized.

Show comment
Hide comment
@sersut

sersut May 13, 2016

Contributor

👍

Contributor

sersut commented May 13, 2016

👍

@scotthain

This comment has been minimized.

Show comment
Hide comment
@scotthain

scotthain May 13, 2016

Contributor

👍 pending happy travis

Contributor

scotthain commented May 13, 2016

👍 pending happy travis

Stephen Lauck
Fixes #107
When configure_from_channel limit remote_file backups to 1.
@sersut

This comment has been minimized.

Show comment
Hide comment
@sersut

sersut May 26, 2016

Contributor

For the curious who is wondering why this did not ship yet, we are waiting for compat_resource to be fixed so that we can run our tests 😄

Contributor

sersut commented May 26, 2016

For the curious who is wondering why this did not ship yet, we are waiting for compat_resource to be fixed so that we can run our tests 😄

@yzl

This comment has been minimized.

Show comment
Hide comment
@yzl

yzl Jun 8, 2016

travis is happy now!

yzl commented Jun 8, 2016

travis is happy now!

@schisamo schisamo merged commit 001757c into master Jun 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schisamo schisamo deleted the lauck/limit_remote_file_backup_to_one branch Jun 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment