New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of default: nil warnings #110

Merged
merged 2 commits into from Jun 6, 2016

Conversation

Projects
None yet
4 participants
@jkeiser
Contributor

jkeiser commented Jun 2, 2016

The default: nil doesn't actually do anything, but in a world of nil setters, it will actively be wrong unless nil becomes a valid value for the resource.

@yzl

This comment has been minimized.

Show comment
Hide comment
@yzl

yzl Jun 2, 2016

👍 pending travis errors

yzl commented Jun 2, 2016

👍 pending travis errors

@scotthain

This comment has been minimized.

Show comment
Hide comment
@scotthain

scotthain Jun 3, 2016

Contributor

👍 pending travis.

Contributor

scotthain commented Jun 3, 2016

👍 pending travis.

@jkeiser

This comment has been minimized.

Show comment
Hide comment
@jkeiser

jkeiser Jun 4, 2016

Contributor

@yzl @scotthain looks like the issue was external, but I made a fix in compat_resource anyway.

Contributor

jkeiser commented Jun 4, 2016

@yzl @scotthain looks like the issue was external, but I made a fix in compat_resource anyway.

@yzl yzl referenced this pull request Jun 4, 2016

Merged

Fix cookbook vs. gem detection under bundler. #67

3 of 4 tasks complete

@jkeiser jkeiser merged commit 43e084b into master Jun 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jkeiser jkeiser deleted the jk/nil-default branch Jun 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment