New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for unstable channel to Debian and RHEL handlers #85

Merged
merged 3 commits into from Mar 28, 2016

Conversation

Projects
None yet
4 participants
@wrightp
Contributor

wrightp commented Mar 9, 2016

The core changes here are in DebianHandler and RhelHandler. The configure_package has been split to support custom repos, source packages, and unstable channel using mixlib-install.

This PR also includes maintenance updates for rubocop and foodcritic.

Known Issues:

  • chefdk upgrade kitchen tests are still broken (known issue)
  • Unstable channel resolution not supported for Windows (a new PR will be created to add a WindowsHandler)
  • Handlers contain some similar and duplicated code. This should be fixed when we implement the WindowsHandler.

TODOs:

  • [ ✔️ ] Remove local test code (synced folders, chef_gem install)
  • [ ✔️ ] release next mixlib-install alpha version and update cookbook

@sersut

@sersut

This comment has been minimized.

Show comment
Hide comment
@sersut

sersut Mar 9, 2016

Contributor

Modulo a minor comment 👍

Can we also add an :unstable test for chef_server @patrick-wright. chefdk test is covering the omnitruck_handler part. Let's make sure we cover the (debian || rhel)_handler path as well.

Contributor

sersut commented Mar 9, 2016

Modulo a minor comment 👍

Can we also add an :unstable test for chef_server @patrick-wright. chefdk test is covering the omnitruck_handler part. Let's make sure we cover the (debian || rhel)_handler path as well.

@sersut

This comment has been minimized.

Show comment
Hide comment
@sersut

sersut Mar 10, 2016

Contributor

👍

One minor thing. Let's annotate the parts of the code that tests with local mixlib-install using TESTING instead of TODO.

Also need to resolve the conflicts.

Let's :shipit:

Contributor

sersut commented Mar 10, 2016

👍

One minor thing. Let's annotate the parts of the code that tests with local mixlib-install using TESTING instead of TODO.

Also need to resolve the conflicts.

Let's :shipit:

@wrightp

This comment has been minimized.

Show comment
Hide comment
@wrightp

wrightp Mar 10, 2016

Contributor

cc @chef-cookbooks/engineering-services

Contributor

wrightp commented Mar 10, 2016

cc @chef-cookbooks/engineering-services

Show outdated Hide outdated .kitchen.yml
chef_ingredient 'chef-server' do
action :install
channel :unstable
version :latest

This comment has been minimized.

@schisamo

schisamo Mar 11, 2016

Contributor

It feels like we should expose artifactory_username and artifactory_password attributes on the chef_ingredient resource. These should be part of the public API of this resource and it's safer than multiple layers of environment variables.

@schisamo

schisamo Mar 11, 2016

Contributor

It feels like we should expose artifactory_username and artifactory_password attributes on the chef_ingredient resource. These should be part of the public API of this resource and it's safer than multiple layers of environment variables.

@wrightp

This comment has been minimized.

Show comment
Hide comment
@wrightp

wrightp Mar 11, 2016

Contributor

See #86 for @schisamo comments

Contributor

wrightp commented Mar 11, 2016

See #86 for @schisamo comments

@wrightp wrightp merged commit 49766f2 into master Mar 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tas50 tas50 deleted the sersut/unstable-server branch Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment