Vagrantfile can't find vagrant-omnibus correctly #38

Merged
merged 1 commit into from Jan 6, 2014

3 participants

@docwhat

Changed the .has_plugin? to use the correct string to detect vagrant-omnibus.

@juliandunn

Hi @docwhat -- just a couple things before we can accept this:

Thanks!

@docwhat docwhat Vagrantfile can't find vagrant-omnibus correctly
The string for detecting the Omnibus plugin has changed: `Omnibus` ->
`vagrant-omnibus`.

Obvious fix.
a9f44a4
@docwhat

@juliandunn

I added "Obvious fix." to the commit message (because it is).

I'll look into signing the ICLA since I'll probably want to contribute more significant fixes in the future.

I'd recommend adding a link to your ticketing system if you don't want to accept patches this way. From a UX point of view, using pull requests is much easier. Can I still use pull requests but include an accompanying ticket pointing at it?

@juliandunn

Yes, we still use pull requests, but need an accompanying JIRA ticket to ensure things get reviewed & merged. I know it's not an ideal process (limitations in GitHub, JIRA and need to make IP ownership clear using the ICLA.)

@btm
btm commented Jan 6, 2014

+1 on this fitting under the obvious fix policy.

Changes that reflect outside facts, like renaming a build directory or changing a constant;
@juliandunn juliandunn merged commit cf8cf49 into chef-cookbooks:master Jan 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment