New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[D-15] Fedora 19 installs Docker 0.8.1, does not have the -G or -e flag #113

Closed
tduffield opened this Issue Apr 3, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@tduffield
Contributor

tduffield commented Apr 3, 2014

Currently, chef-docker on Fedora 19 installs Docker 0.8.1 which does not support the -G or -e flag, both of which were added in Docker 0.9.

Potential solutions:

  • logic check to determine whether flags should be present
  • install from source/binary if Fedora 19 is detected
@tduffield

This comment has been minimized.

Contributor

tduffield commented Apr 3, 2014

Decided that solution 1 made more sense.

@bflad

This comment has been minimized.

Collaborator

bflad commented Apr 6, 2014

@tduffield what's our threshold for backwards compatibility? I've been writing most functionality here with the assumption that we'll keep adding functionality until Docker 1.0 is cut. Although I do see the point that both of those are set with default values so it tries to add the flags. We could set almost all attributes to nil so they won't try to be set by default. Let me do some analysis today.

@bflad bflad closed this in a8d6f15 Apr 6, 2014

@bflad

This comment has been minimized.

Collaborator

bflad commented Apr 6, 2014

Defaulted both exec_driver and group to nil since it makes sense and protected group recipe from the change. Added note to README about LXC before Docker 0.9.0, although maybe we could explicitly include_recipe 'lxc' for platform fedora and platform_version 19? Also of note, FC19 docker-io 0.9.1 package does exist: http://koji.fedoraproject.org/koji/buildinfo?buildID=507488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment