New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how service actions are invoked. #200

Merged
merged 2 commits into from Oct 24, 2014

Conversation

Projects
None yet
4 participants
@brianhartsock
Contributor

brianhartsock commented Aug 2, 2014

Fixes issue #194 and #198 I think.

This pull request is some initial thoughts on how to prevent docker service definitions from squashing over each others actions. Here, the service should (most likely) only be defined once and from there have it's action invoked immediately. Using this immediately fixed issues I had with redeploy.

Another possible solutions could be using docker rm instead of service_action(:stop) in def stop.

This may or may not be the best way to solve this problem but I at least wanted to throw this up to get some feedback.

@rdsubhas

This comment has been minimized.

Show comment
Hide comment
@rdsubhas

rdsubhas Aug 11, 2014

would be great if this fixes the issue, because we're having random failures during deployment (failed to stop container, remove image, etc)!

Trying to get @bflad 's attention 👍

rdsubhas commented Aug 11, 2014

would be great if this fixes the issue, because we're having random failures during deployment (failed to stop container, remove image, etc)!

Trying to get @bflad 's attention 👍

@djdefi

This comment has been minimized.

Show comment
Hide comment
@djdefi

djdefi Sep 12, 2014

+1 would love a new release with this and some of the other merge requests.

djdefi commented Sep 12, 2014

+1 would love a new release with this and some of the other merge requests.

tduffield pushed a commit that referenced this pull request Oct 24, 2014

@tduffield tduffield merged commit 402dea0 into chef-cookbooks:master Oct 24, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

tduffield pushed a commit that referenced this pull request Nov 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment