New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed pull notification for tagged images #203

Merged
merged 1 commit into from Oct 24, 2014

Conversation

Projects
None yet
4 participants
@hobofan
Contributor

hobofan commented Aug 19, 2014

The image pull action now uses image_and_tag_arg instead of only the image_name.

Only comparing the id of the image with the image_name will result in no update of the resource when you are actually pulling a tagged image and therefore no notify actions will be raised.

@sniperd

This comment has been minimized.

sniperd commented Sep 11, 2014

+1 to this fix, I am now using this fork/branch as the current one is non functional in any meaningful deployment scenario for me.

If you use a tag with the docker_image resource and have any notifies/subscribes -- nothing will work without this fix. For my use case having a tag and not downloading the world from my registry is important.

Without this fix the entire cookbook seems broken when using tags and will result in much frustration. Please merge.

@djdefi

This comment has been minimized.

djdefi commented Sep 17, 2014

+1 need some of these fixes merged. We are about to scrap using this cookbook and switch to Ansible's docker module or something else that is being maintained.

@tduffield

This comment has been minimized.

Contributor

tduffield commented Oct 13, 2014

👍

tduffield pushed a commit that referenced this pull request Oct 24, 2014

Tom Duffield
Merge pull request #203 from hobofan/fix_pull_with_tags
fixed pull notification for tagged images

@tduffield tduffield merged commit d5543f4 into chef-cookbooks:master Oct 24, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment