New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed current_resource.name assignment in providers. #205

Merged
merged 1 commit into from Oct 24, 2014

Conversation

Projects
None yet
2 participants
@jperville
Contributor

jperville commented Aug 29, 2014

While investigating another issue, I found out that the load_current_resource methods all providers initialize the current_resource with the new_resource instance. This is incorrect (even if this does not stop the resources from converging) but it makes inspecting the current_resource more difficult to read (the name attribute will be an object instead of the expected string).

In the example given in the official documentation the current_resource is instantiated using the new_resource name attribute, which is exactly what this PR does.

@tduffield

This comment has been minimized.

Contributor

tduffield commented Oct 13, 2014

👍

tduffield pushed a commit that referenced this pull request Oct 24, 2014

Tom Duffield
Merge pull request #205 from jperville/fix-current-resource-name-in-p…
…roviders

Use new_resource.name as parameter value instead of new_resource in providers.

@tduffield tduffield merged commit 2520194 into chef-cookbooks:master Oct 24, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@jperville

This comment has been minimized.

Contributor

jperville commented Oct 25, 2014

Thank you very much for the merge @tduffield

@jperville jperville deleted the PerfectMemory:fix-current-resource-name-in-providers branch Oct 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment