Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some various cleanup and fixes for this cookbook #29

Merged
merged 4 commits into from Apr 20, 2015

Conversation

Projects
None yet
3 participants
@jtimberman
Copy link
Member

commented Apr 20, 2015

See the commit messages

/cc @cmluciano

jtimberman added some commits Apr 20, 2015

Lint fixes, rubocop and foodcritic
* Ignore FC005, we don't want this resource in the resource collection
  if the condition is met
* Ignore spacing in metadata; updated rubocop config
* Apply rubocop auto corrected fixes
Updates for esl and package recipes
* Fail if attempting to use ESL on RHEL-family v5.x, as the dependencies
  for esl-erlang are not available on v5. Blindly continuing leads to a
  broken system - erlang isn't installed, so we fail early with the
  informative log message.
* Don't actually add the erlang solutions yum repo in the "normal"
  package recipe, as that may lead to the wrong erlang package - the
  intention of the recipe is to use EPEL
* On RHEL-family v5 in the package recipe, we need to disable SSL
  verification because the repository used redirects to HTTPS, and
  there's an underlying bug in the redirect code for yum that causes the
  certificate to not be verifiable, even though it is valid.

Fixes #28, might fix #9
@cmluciano

This comment has been minimized.

Copy link
Contributor

commented Apr 20, 2015

👍👍👍👍👍
This cleanup looks great @jtimberman

jtimberman added a commit that referenced this pull request Apr 20, 2015

Merge pull request #29 from opscode-cookbooks/jtimberman/cleanup-and-…
…fixes

Some various cleanup and fixes for this cookbook

@jtimberman jtimberman merged commit 0fed1cf into master Apr 20, 2015

@jtimberman jtimberman deleted the jtimberman/cleanup-and-fixes branch Apr 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.