Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple issues with ~FC023 #341

Merged
merged 1 commit into from Apr 27, 2017

Conversation

Projects
None yet
3 participants
@EasyAsABC123
Copy link
Collaborator

commented Apr 25, 2017

Signed-off-by: Justin Schuhmann jmschu02@gmail.com

Description

Resolves multiple issues caused by recommendations from FC023 rule, only_if and not_if are ignored for converge_if_changed and converge_by

Issues Resolved

#340

Check List

@tas50

This comment has been minimized.

Copy link
Member

commented Apr 25, 2017

We actually retired FC023 because it caused problems like these.

@EasyAsABC123

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 25, 2017

@tas50 yeah i read the documentation but feel for it all the same...saw deprecated but still thought that the converge_* functions would work with not_if and only_if..testing locally to make the test pass (inspec can't access node so need to verify the computer name)

Fix multiple issues with ~FC023
Signed-off-by: Justin Schuhmann <jmschu02@gmail.com>

@EasyAsABC123 EasyAsABC123 force-pushed the fix-pool_custom_resource branch from 3b6956c to 0a6443a Apr 25, 2017

@iennae

iennae approved these changes Apr 26, 2017

Copy link
Contributor

left a comment

LGTM. is site_identifier used at all now?

@EasyAsABC123

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 27, 2017

@iennae not in the iis_app

@EasyAsABC123 EasyAsABC123 merged commit 4e46a38 into master Apr 27, 2017

2 checks passed

DCO This commit has a DCO Signed-off-by
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@EasyAsABC123 EasyAsABC123 deleted the fix-pool_custom_resource branch Apr 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.