Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iis_pool identity_type issue #362

Merged
merged 1 commit into from May 16, 2017

Conversation

Projects
None yet
4 participants
@EasyAsABC123
Copy link
Collaborator

commented May 16, 2017

Description

Fixes an issue with iis_pool not updating identity_type due to a missed identity and bad if statement for chef-client 13 since the default isn't empty string on these variables anymore

Issues Resolved

#360

Check List

Fix iis_pool identity_type issue
Signed-off-by: Justin Schuhmann <jmschu02@gmail.com>

@EasyAsABC123 EasyAsABC123 force-pushed the fix-iis_poolidentity_type branch from 5a02dc9 to a6f6ca4 May 16, 2017

@iennae

iennae approved these changes May 16, 2017

Copy link
Contributor

left a comment

LG. Thanks for the quick turn around!

@EasyAsABC123 EasyAsABC123 merged commit 516d052 into master May 16, 2017

2 checks passed

DCO This commit has a DCO Signed-off-by
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@EasyAsABC123 EasyAsABC123 deleted the fix-iis_poolidentity_type branch May 16, 2017

@stevenoneill

This comment has been minimized.

Copy link

commented May 16, 2017

Thanks for the quick work! Super awseome!

kamaradclimber added a commit to criteo-forks/iis that referenced this pull request Jul 18, 2017

Integrate upstream changes
Most of the merge work is based on the fact that pool provider has been
replaced by a custom resource.

From all the non-merged criteo patches:
51e609a Fix decoding of entities in XML
5034448 Clarify execute tasks
43186f1 Activate use_inline_resources
99c4187 Remove unnecessary Chef logs
280fba8 Fix regression introduced with whyrun support
e85ca2f Fix the site_identifier privacy so that the execute context can use it
12ac82f Post review fixes
d534851 Removed new_resource.updated_by_last_action occurences
f9b773d Make the pool provider whyrun able

all are either unnecessary or correctly applied

* 'master' of https://github.com/chef-cookbooks/iis: (145 commits)
  Adds better documentation for the options parameter (chef-cookbooks#383)
  release 6.7.2 (chef-cookbooks#382)
  Fix FTP site binding error (chef-cookbooks#380)
  Release v6.7.1 (chef-cookbooks#379)
  Fix issue with guard clause missing on check (chef-cookbooks#378)
  Release v6.7.0 (chef-cookbooks#376)
  fix multiple bugs with iis_vdir iis_root iis_app for idempotency (chef-cookbooks#375)
  Release v6.6.0 (chef-cookbooks#373)
  Update appveyor.yml
  Enhancement module custom resource (chef-cookbooks#372)
  Fix README.md (chef-cookbooks#367)
  Release v6.5.3 (chef-cookbooks#371)
  Resolves a bug in iis_vdir also adds more liberty in config (chef-cookbooks#370)
  Refactor vdir name property to site_name (chef-cookbooks#359)
  Release v6.5.2 (chef-cookbooks#364)
  Update iis_vdir name to not require a trailing / (chef-cookbooks#363)
  Fix iis_pool identity_type issue (chef-cookbooks#362)
  Release v6.5.1 (chef-cookbooks#358)
  Add quotes to pool name (chef-cookbooks#357)
  Release v6.5.0 (chef-cookbooks#352)
  ...

Change-Id: I951fb2d1788d877c98b24bb22cb5d035162e146d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.