New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing default to stable, adding channel toggle #575

Merged
merged 3 commits into from Mar 8, 2017

Conversation

Projects
None yet
3 participants
@cheeseplus
Contributor

cheeseplus commented Mar 8, 2017

Signed-off-by: Seth Thomas sthomas@chef.io

Description

  • set "stable" as the default channel for Jenkins and plugins
  • .kitchen.docker.yml -> .kitchen.dokken.yml
  • use delivery local in travis
  • misc test fixes

Issues Resolved

n/a

Check List

Changing default to stable, adding channel toggle
Signed-off-by: Seth Thomas <sthomas@chef.io>
@tas50

tas50 approved these changes Mar 8, 2017

Stable!

@iennae

I think overall this looks good, just not sure about the addition of the derived attribute. It feels like the repository location should just be a variable versus a node attribute.

Show outdated Hide outdated attributes/master.rb
Recalibrating cleverness
Signed-off-by: Seth Thomas <sthomas@chef.io>
@iennae

iennae approved these changes Mar 8, 2017

@cheeseplus cheeseplus merged commit 6d961cb into master Mar 8, 2017

0 of 2 checks passed

DCO This commit does not have a DCO Signed-off-by
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment