COOK-4033 only set http_realip_recursive if nginx version is > 1.2.1 #174

Merged
merged 1 commit into from Mar 14, 2015

Conversation

Projects
None yet
3 participants
@aaronbbrown

Per http://wiki.nginx.org/HttpRealipModule, the real_ip_recursive parameter is only available in nginx > 1.2.1

@aaronbbrown

This comment has been minimized.

Show comment
Hide comment
@aaronbbrown

aaronbbrown Dec 30, 2013

Foodcritic failed this on something that was unrelated to my commit:

recipes/package.rb:36:3: C: Favor modifier if/unless usage when you have a single-line body. Another good > alternative is the usage of control flow &&/||.
if node['nginx']['repo_source'] == 'nginx'
^^

Can this get pull request please get merged in?

Foodcritic failed this on something that was unrelated to my commit:

recipes/package.rb:36:3: C: Favor modifier if/unless usage when you have a single-line body. Another good > alternative is the usage of control flow &&/||.
if node['nginx']['repo_source'] == 'nginx'
^^

Can this get pull request please get merged in?

@aaronbbrown aaronbbrown deleted the aaronbbrown:COOK-4033 branch Dec 31, 2013

@aaronbbrown aaronbbrown restored the aaronbbrown:COOK-4033 branch Dec 31, 2013

@aaronbbrown aaronbbrown reopened this Dec 31, 2013

@maxstepanov

This comment has been minimized.

Show comment
Hide comment
@maxstepanov

maxstepanov Feb 4, 2014

This bug breaks this cookbook on Ubuntu LTS Precise.

This bug breaks this cookbook on Ubuntu LTS Precise.

@miketheman miketheman added the bug label Aug 23, 2014

@miketheman miketheman added this to the Triage milestone Aug 23, 2014

@miketheman miketheman self-assigned this Sep 15, 2014

@miketheman

This comment has been minimized.

Show comment
Hide comment
@miketheman

miketheman Nov 20, 2014

Collaborator

@9minutesnooze I spent no small amount of time on this seemingly trivial change.

Since the version attribute can be set both manually by an operator, and then overridden by an ohai plugin, there's some confusion as to who "owns" that particular attribute.

Using the attribute here to wrap this particular directive doesn't seem to work consistently, and the default version provided in Ubuntu 12.04 it still a version below the supported directive.

I am inclined to leave this as is, until we can get a better test harness around "who sets the version" semantics worked out, and then leverage the correct version mod then.

If anyone has some ideas on how to better test this behavior, please, don't hesitate to speak up. Otherwise, I'll have to come back to it when we can test the version attribute setting.

Collaborator

miketheman commented Nov 20, 2014

@9minutesnooze I spent no small amount of time on this seemingly trivial change.

Since the version attribute can be set both manually by an operator, and then overridden by an ohai plugin, there's some confusion as to who "owns" that particular attribute.

Using the attribute here to wrap this particular directive doesn't seem to work consistently, and the default version provided in Ubuntu 12.04 it still a version below the supported directive.

I am inclined to leave this as is, until we can get a better test harness around "who sets the version" semantics worked out, and then leverage the correct version mod then.

If anyone has some ideas on how to better test this behavior, please, don't hesitate to speak up. Otherwise, I'll have to come back to it when we can test the version attribute setting.

@miketheman miketheman removed this from the Triage Round 1 milestone Nov 20, 2014

miketheman added a commit that referenced this pull request Mar 14, 2015

Merge pull request #174 from 9minutesnooze/COOK-4033
COOK-4033 only set http_realip_recursive if nginx version is > 1.2.1

@miketheman miketheman merged commit c5839a7 into chef-cookbooks:master Mar 14, 2015

1 check failed

default The Travis CI build failed
Details

@miketheman miketheman modified the milestone: 2.7.5 Mar 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment