Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
COOK-4033 only set http_realip_recursive if nginx version is > 1.2.1 #174
Foodcritic failed this on something that was unrelated to my commit:
Can this get pull request please get merged in?
@9minutesnooze I spent no small amount of time on this seemingly trivial change.
Since the version attribute can be set both manually by an operator, and then overridden by an ohai plugin, there's some confusion as to who "owns" that particular attribute.
Using the attribute here to wrap this particular directive doesn't seem to work consistently, and the default version provided in Ubuntu 12.04 it still a version below the supported directive.
I am inclined to leave this as is, until we can get a better test harness around "who sets the version" semantics worked out, and then leverage the correct version mod then.
If anyone has some ideas on how to better test this behavior, please, don't hesitate to speak up. Otherwise, I'll have to come back to it when we can test the version attribute setting.