Allow people to define their own nginx.conf templates. #184

Merged
merged 3 commits into from Mar 14, 2015

Conversation

Projects
None yet
3 participants
@joestump

joestump commented Jan 3, 2014

  • Fixed up the Chefspec matchers to work and added them to the spec helpers.
  • Added the ability to define your own nginx.conf template in your own cookbook if you so choose.
  • Added Chefspec coverage for new options.

I'd still like to address being able to leverage the matchers in other cookbooks, but I'll leave that for another PR.

@joestump

This comment has been minimized.

Show comment
Hide comment
@joestump

joestump Apr 4, 2014

Updated this with master.

joestump commented Apr 4, 2014

Updated this with master.

@jujugrrr

This comment has been minimized.

Show comment
Hide comment
@jujugrrr

jujugrrr Aug 28, 2014

@miketheman enhancement. @joestump Thanks for the PR, it makes the cookbook easier to integrate/tune 👍 , +1 for the tests

@miketheman enhancement. @joestump Thanks for the PR, it makes the cookbook easier to integrate/tune 👍 , +1 for the tests

@miketheman miketheman added this to the Triage milestone Aug 29, 2014

@miketheman miketheman modified the milestones: 2.7.5, Triage Round 1 Mar 14, 2015

miketheman added a commit that referenced this pull request Mar 14, 2015

Merge pull request #184 from tvdinner/nginx.conf-configuration-options
Allow people to define their own nginx.conf templates.

@miketheman miketheman merged commit 8c3e8cf into chef-cookbooks:master Mar 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment