Add documentation of gzip_static configuration #249

Merged
merged 1 commit into from Mar 14, 2015

Conversation

Projects
None yet
3 participants
@whatcould
Contributor

whatcould commented Aug 6, 2014

The attribute was added (aa68b47 ) but it was not documented in the README. I had to dig for it.

I wonder if adding http_gzip_static_module should set node['nginx']['gzip_static'] = 'yes' by default? That seems like the principle of least surprise. It took me a while to figure out why my .gz files were not being served even though I had enabled the module.

@miketheman miketheman added the trivial label Aug 23, 2014

@miketheman miketheman added this to the Triage milestone Aug 23, 2014

miketheman added a commit that referenced this pull request Mar 14, 2015

Merge pull request #249 from whatcould/master
Add documentation of gzip_static configuration

@miketheman miketheman merged commit f4b405c into chef-cookbooks:master Mar 14, 2015

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details

@miketheman miketheman modified the milestones: 2.7.5, Triage Round 1 Mar 14, 2015

@yveslaroche

This comment has been minimized.

Show comment
Hide comment
@yveslaroche

yveslaroche Mar 17, 2015

For better performance use this only in a location block.

https://github.com/h5bp/server-configs-nginx/blob/master/nginx.conf#L112-L115

This should be turned on if you are going to have pre-compressed copies (.gz) of
static files available. If not it should be left off as it will cause extra I/O
for the check. It is best if you enable this in a location{} block for
a specific directory, or on an individual server{} level.

For better performance use this only in a location block.

https://github.com/h5bp/server-configs-nginx/blob/master/nginx.conf#L112-L115

This should be turned on if you are going to have pre-compressed copies (.gz) of
static files available. If not it should be left off as it will cause extra I/O
for the check. It is best if you enable this in a location{} block for
a specific directory, or on an individual server{} level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment