Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COOK-3330] Only adds the helper on windows (fixes crashes on *nix) #5

Merged
merged 1 commit into from Dec 4, 2013

Conversation

@skoczen
Copy link
Contributor

skoczen commented Sep 27, 2013

This fixes a critical bug (anything that includes powershell (even if it's not added as a recipe) won't run at all on *nix, including berkshelf.)

Should fix this ticket: https://tickets.opscode.com/browse/COOK-3330

Caveats: I don't have a windows system to test on - can't guarantee functionality stays as desired on Win, but it should.

@sethvargo

This comment has been minimized.

Copy link
Contributor

sethvargo commented Oct 15, 2013

Ohai @skoczen! Thank you for contributing to Opscode cookbooks. Do you have a signed CLA with Opscode? I could not find you in our JIRA system or on the list of approved contributors. In order to merge this change, we need a signed CLA and an account in our JIRA ticketing system. Here's our wiki page that has more detail: https://wiki.opscode.com/display/chef/How+to+Contribute

@jbaudanza

This comment has been minimized.

Copy link

jbaudanza commented Nov 27, 2013

👍 for this PR which fixes a critical bug
👎 for requiring a signed CLA for a 3 line change

@sethvargo

This comment has been minimized.

Copy link
Contributor

sethvargo commented Nov 27, 2013

@jbaudanza we recently implemented a Trivial Patch Policy. I'm investigating if this qualifies under those guidelines.

@btm

This comment has been minimized.

Copy link
Contributor

btm commented Dec 4, 2013

http://docs.opscode.com/community_contributions.html

Changes that reflect outside facts, like renaming a build directory or changing a constant;

Looks good to me, thanks @jbaudanza. I wish copyright could be as easy as an established minimum number of characters or lines.

sethvargo pushed a commit that referenced this pull request Dec 4, 2013
[COOK-3330] Only adds the helper on windows (fixes crashes on *nix)
@sethvargo sethvargo merged commit 0f8b204 into chef-cookbooks:master Dec 4, 2013
@klausmeyer

This comment has been minimized.

Copy link

klausmeyer commented Dec 29, 2013

i'm not getting this fix when installing the cookbook using berkshelf.
can someone please bump the version or whatever is necessary to update the api?

@troygoode

This comment has been minimized.

Copy link

troygoode commented Dec 30, 2013

what @klausmeyer said...

@EvanPurkhiser

This comment has been minimized.

Copy link

EvanPurkhiser commented Dec 30, 2013

Also reiterating what @klausmeyer said 👍

@klausmeyer

This comment has been minimized.

Copy link

klausmeyer commented Jan 3, 2014

Thanks guys. Now the cookbook installed via berkshelf from the site is working for me again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.