Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing logic to enable use of named instances #59

Merged

Conversation

Projects
None yet
5 participants
@svanharmelen
Copy link
Contributor

commented Feb 16, 2016

This change enables the creation of named instances (e.g. MSSQL$MYINSTANCE). Before you could only have a default instance if your not using SQLEXPRESS.

Sander van Harmelen
Changing logic to enable use of named instances
This change enables the creation of named instances (e.g.
MSSQL$MYINSTANCE). Before you could only have a default instance if
your not using SQLEXPRESS.
@Annih

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2016

I think the title of your PR should be Fix logic to determine service name, because it is actually buggy for named instances setup.

Thanks for this PR @svanharmelen ;)

@Annih

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2016

Actually it would fix #39

@mwrock

This comment has been minimized.

Copy link
Member

commented May 16, 2016

👍 this is absolutely a bug fix. The travis failure is unrelated to this PR

@mwrock

This comment has been minimized.

Copy link
Member

commented May 16, 2016

It would not be a bad idea to rebase this on master @svanharmelen which will likely get this to green.

@smurawski smurawski merged commit 4930c06 into chef-cookbooks:master May 17, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

smurawski added a commit that referenced this pull request May 17, 2016

Merge pull request #59 from schubergphilis/support-named-instances
Changing logic to enable use of named instances
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.