Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Standard Edition #67

Conversation

Projects
None yet
4 participants
@rhealitycheck
Copy link
Contributor

commented May 10, 2016

Description

Instance name is modified because SQLEXPRESS is used as an instance name for SQL Server. In Standard or Enterprise installs, SQL Server will default to MSSQLSERVER. Any instance name declared by the user will have MSSQL$ appeneded to the front as the service name.
Agent name needs to be declared because if you use the SQL Agent, you need to restart both services as the Agent is dependent on the SQL Service
If you have declared an agent account it will restart both the agent service and the sql service. If not only restart the sql service
Also added return codes because the install periodically returns 3010 which means a reboot is pending and is not an actual error, the other return codes were taken from the chef output.
SQL Server requires a reboot to complete your install

Issues Resolved

N/A

Check List

Updates for Standard Edition
Instance name is modified because SQLEXPRESS is used as an instance name for SQL Server. In Standard or Enterprise installs, SQL Server will default to MSSQLSERVER. Any instance name declared by the user will have MSSQL$ appeneded to the front as the service name.
Agent name needs to be declared because if you use the SQL Agent, you need to restart both services as the Agent is dependent on the SQL Service
If you have declared an agent account it will restart both the agent service and the sql service. If not only restart the sql service
SQL Server requires a reboot to complete your install
Update server.rb
fixed linting issues.

@smurawski smurawski merged commit 79ac96b into chef-cookbooks:master May 17, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

smurawski added a commit that referenced this pull request May 17, 2016

Merge pull request #67 from rhealitycheck/rhealitycheck-updates-for-s…
…tandard-edition

Updates for Standard Edition
service agent_service_name do
action [:start, :enable]
end
service service_name do

This comment has been minimized.

Copy link
@Annih

Annih May 17, 2016

Contributor

Duplicate definition of the service

@Annih

This comment has been minimized.

Copy link
Contributor

commented May 17, 2016

Hi @smurawski
I saw that you are preparing the new 2.6.0 release including this patch. I think it should be clearer in the changelog or the version number that the cookbook is now rebooting the node.

BTW you should also update the README stating that chef12+ is now required, because this patch leverages the reboot lwrp.

@rhealitycheck rhealitycheck referenced this pull request May 17, 2016

Merged

cleaning up duplicate service restart for sql service #69

4 of 4 tasks complete
@smurawski

This comment has been minimized.

Copy link
Contributor

commented May 17, 2016

@Annih Thanks! Good catch. I'm getting some readme updates together for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.