New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COOK-3643] Fix freebsd #34

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@clewis
Contributor

clewis commented Sep 12, 2013

https://tickets.opscode.com/browse/COOK-3643

Some changes I made to get this cookbook to run correctly on FreeBSD.

@jesseadams

This comment has been minimized.

Show comment
Hide comment
@jesseadams

jesseadams Sep 12, 2013

Hey @clewis! Thank you for supporting the Opscode Cookbooks! Opscode's process has a couple prerequisites before they will merge your contribution. We need to ensure you've completed a Contributor License Agreement (CLA) and a ticket on their ticket tracker for the release workflow. Pull requests are optional, but should always include the ticket number that they're related to for cross-referencing. Please take a moment to review the below wiki page for the appropriate steps:

jesseadams commented Sep 12, 2013

Hey @clewis! Thank you for supporting the Opscode Cookbooks! Opscode's process has a couple prerequisites before they will merge your contribution. We need to ensure you've completed a Contributor License Agreement (CLA) and a ticket on their ticket tracker for the release workflow. Pull requests are optional, but should always include the ticket number that they're related to for cross-referencing. Please take a moment to review the below wiki page for the appropriate steps:

@clewis

This comment has been minimized.

Show comment
Hide comment
@clewis

clewis Sep 12, 2013

Contributor

Thanks for the info. I am contributing on behalf of a company, so I'll need to figure out our own procedure for these things.

Contributor

clewis commented Sep 12, 2013

Thanks for the info. I am contributing on behalf of a company, so I'll need to figure out our own procedure for these things.

@jesseadams

This comment has been minimized.

Show comment
Hide comment
@jesseadams

jesseadams Sep 12, 2013

@clewis - Good luck 😉

jesseadams commented Sep 12, 2013

@clewis - Good luck 😉

@clewis

This comment has been minimized.

Show comment
Hide comment
@clewis

clewis Sep 19, 2013

Contributor

I created ticket https://tickets.opscode.com/browse/COOK-3643 , but I can't figure out how to change the status to 'Fix Provided'.

Contributor

clewis commented Sep 19, 2013

I created ticket https://tickets.opscode.com/browse/COOK-3643 , but I can't figure out how to change the status to 'Fix Provided'.

@jesseadams

This comment has been minimized.

Show comment
Hide comment
@jesseadams

jesseadams Sep 19, 2013

@clewis - Did you sign the CLA using the same email address that you used for your tickets.opscode.com account?

jesseadams commented Sep 19, 2013

@clewis - Did you sign the CLA using the same email address that you used for your tickets.opscode.com account?

@clewis

This comment has been minimized.

Show comment
Hide comment
@clewis

clewis Sep 19, 2013

Contributor

My boss filled out the Corporate Contributors agreement. It had some effect, because I wasn't able to create tickets before.

Contributor

clewis commented Sep 19, 2013

My boss filled out the Corporate Contributors agreement. It had some effect, because I wasn't able to create tickets before.

@jesseadams

This comment has been minimized.

Show comment
Hide comment
@jesseadams

jesseadams Sep 20, 2013

@clewis - The email address used to sign the CLA must match the CLA used to create the account at tickets.opscode.com. Also, you may have not been reviewed by Opscode legal yet. An email confirmation will come through when that is complete. Then the button should show up.

jesseadams commented Sep 20, 2013

@clewis - The email address used to sign the CLA must match the CLA used to create the account at tickets.opscode.com. Also, you may have not been reviewed by Opscode legal yet. An email confirmation will come through when that is complete. Then the button should show up.

@btm

This comment has been minimized.

Show comment
Hide comment
@btm

btm Sep 23, 2013

It looks like your CCLA has been processed. You're on the approved contributors list now as #1705. I've clicked Fix Provided on COOK-3643 for you, which you should now see on tickets in the future.

btm commented Sep 23, 2013

It looks like your CCLA has been processed. You're on the approved contributors list now as #1705. I've clicked Fix Provided on COOK-3643 for you, which you should now see on tickets in the future.

@clewis

This comment has been minimized.

Show comment
Hide comment
@clewis

clewis Sep 23, 2013

Contributor

@btm I am seeing the permissions in Jira that I need. I just jumped the gun a few times. Thanks for the help.

Contributor

clewis commented Sep 23, 2013

@btm I am seeing the permissions in Jira that I need. I just jumped the gun a few times. Thanks for the help.

@sethvargo

This comment has been minimized.

Show comment
Hide comment
@sethvargo

sethvargo Sep 27, 2013

Contributor

Hey @clewis thank you for the contribution! There are a few issues that we'd like you to address:

  1. It looks like theres a merge conflict in the code in the attributes file. Could you take a look at that?

  2. Can you add FreeBSD to the supports key in the metadata.rb?

  3. Can you add FreeBSD to the README as a supported platform?

  4. We prefer String-quoted (instead of symbols) for attribute accessing, and it's actually a foodcritic rule (so the build will fail):

    node[:foo][:bar] => node['foo']['bar']

After you've made those changes, can you please re-mark the ticket as "Fix Provided" in JIRA and we can re-review 😄!

Contributor

sethvargo commented Sep 27, 2013

Hey @clewis thank you for the contribution! There are a few issues that we'd like you to address:

  1. It looks like theres a merge conflict in the code in the attributes file. Could you take a look at that?

  2. Can you add FreeBSD to the supports key in the metadata.rb?

  3. Can you add FreeBSD to the README as a supported platform?

  4. We prefer String-quoted (instead of symbols) for attribute accessing, and it's actually a foodcritic rule (so the build will fail):

    node[:foo][:bar] => node['foo']['bar']

After you've made those changes, can you please re-mark the ticket as "Fix Provided" in JIRA and we can re-review 😄!

clewis added some commits Sep 27, 2013

Included recommended defaults for FreeBSD in the README.
metadata.rb already says this recipe supports FreeBSD.
Fix foodcritic message:
Use single-quoted strings as hash keys instead of symbols.
@sethvargo

This comment has been minimized.

Show comment
Hide comment
@sethvargo

sethvargo Jan 27, 2014

Contributor

It looks like these have been fixed in the master branch.

Contributor

sethvargo commented Jan 27, 2014

It looks like these have been fixed in the master branch.

@sethvargo sethvargo closed this Jan 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment