automate-gateway: cleanup GRPC/HTTP multiplexing cruft #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was carried over from some ancient grpc-gateway example code[1]; and we're not exposing the GRPC API that way right now. Using (*grpc.Server).ServeHTTP has some issues: 1. it's known to be slow, very slow[2] 2. it's seems to be not working with go-grpc >= 1.19 [3] Furthermore, we're exposing the proper GRPC server (the native go-grpc one) on a different port. If decide to (finally!) expose our GRPC API, that's the thing we should expose. So, since we don't need this multiplexing business, we shouldn't keep the code around. This is the cleanup. [1]: https://github.com/philips/grpc-gateway-example/ [2]: grpc/grpc-go#586 [3]: soheilhy/cmux#64 (comment) Signed-off-by: Stephan Renatus <srenatus@chef.io>
So apparently these HAD used the multiplexing code I've deleted. Well, they don't have to. Changed the hardcoded port to automate-gateway's default grpc port. Signed-off-by: Stephan Renatus <srenatus@chef.io>
stevendanna
approved these changes
May 22, 2019
|
✔️ trivial PR. merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description
This was carried over from some ancient grpc-gateway example code1; and
we're not exposing the GRPC API that way right now.
Using (*grpc.Server).ServeHTTP has some issues:
Furthermore, we're exposing the proper GRPC server (the native go-grpc
one) on a different port. If decide to (finally!) expose our GRPC API,
that's the thing we should expose.
So, since we don't need this multiplexing business, we shouldn't keep
the code around. This is the cleanup.