New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policyfile CLI #157

Merged
merged 21 commits into from Sep 15, 2014

Conversation

Projects
None yet
4 participants
@danielsdeleo
Member

danielsdeleo commented Sep 12, 2014

Implements chef install and chef push. Before we merge/ship, should probably document how to configure chef-client for policyfile mode. Also need to ship a new chef-client alpha gem with the WorkstationConfigLoader in it before we can merge and build correctly.

/cc @opscode/client-engineers

danielsdeleo added some commits Sep 3, 2014

Add 'Install' service
Implements behavior of (not yet created) `chef install` command, but is
implemented as library code (ui object is DI'd, errors are raised as
exceptions, etc.) so it can be re-used outside of the chef-dk command
line.
Show outdated Hide outdated CHANGELOG.md Outdated
Show outdated Hide outdated lib/chef-dk/command/install.rb Outdated
@mcquin

This comment has been minimized.

Show comment
Hide comment
@mcquin

mcquin Sep 12, 2014

Contributor

Yay this is awesome! In terms of slight code refactoring: would it make sense to have a ui_helpers module for cookbook_name_width and a policyfile_helpers for all the _path/_relative_path methods?

Contributor

mcquin commented Sep 12, 2014

Yay this is awesome! In terms of slight code refactoring: would it make sense to have a ui_helpers module for cookbook_name_width and a policyfile_helpers for all the _path/_relative_path methods?

@danielsdeleo

This comment has been minimized.

Show comment
Hide comment
@danielsdeleo

danielsdeleo Sep 15, 2014

Member

@mcquin yep, you're right. I had planned to move all the path/relative path code into the StorageConfig class, but decided not to so I could get the pull request up. If I have time today I'll try to get that done, otherwise I'll leave a note in LeanKit to clean that up. I'll move the report stuff out to their own part of the file tree and try to extract some shared code there.

Member

danielsdeleo commented Sep 15, 2014

@mcquin yep, you're right. I had planned to move all the path/relative path code into the StorageConfig class, but decided not to so I could get the pull request up. If I have time today I'll try to get that done, otherwise I'll leave a note in LeanKit to clean that up. I'll move the report stuff out to their own part of the file tree and try to extract some shared code there.

@danielsdeleo danielsdeleo merged commit 7bee884 into master Sep 15, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@danielsdeleo danielsdeleo deleted the policyfile-cli branch Sep 15, 2014

@danielsdeleo

This comment has been minimized.

Show comment
Hide comment
@danielsdeleo
Member

danielsdeleo commented Sep 15, 2014

@mcquin will follow up on the duplicate logic later: https://chef.leankit.com/Boards/View/89094477/128109397

ksubrama pushed a commit that referenced this pull request Jan 11, 2016

Serdar Sutay
Merge pull request #157 from opscode/jo/chefdk-images
updating bitmap images to include Gotham Font to make all logos have som...

@chef chef locked and limited conversation to collaborators Feb 14, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.