New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow EC2/IAM endpoint configuration #34

Merged
merged 1 commit into from Aug 18, 2014

Conversation

Projects
None yet
3 participants
@viglesiasce
Contributor

viglesiasce commented Jul 16, 2014

This commit allows configuration via environment variables as well as compute_options provided in
a recipe.

Examples:
with_driver 'fog:AWS', :compute_options => { :aws_access_key_id => 'YYYYYYYYYYYYYYYYY',
:aws_secret_access_key => 'XXXXXXXXXXXXXXXXXXXXXXX',
:ec2_endpoint => 'http://10.111.1.136:8773/services/compute/',
:iam_endpoint => 'http://10.111.1.136:8773/services/Euare/'}

Or use the following environment variables:
EC2_URL
AWS_IAM_URL

Allow EC2/IAM endpoint configuration
This commit allows configuration via environment
variables as well as compute_options provided in
a recipe.
@chef-supermarket

This comment has been minimized.

Show comment
Hide comment
@chef-supermarket

chef-supermarket Jul 16, 2014

Hi. Your friendly Curry bot here. Just letting you know that there are commit authors in this Pull Request who appear to not have signed a Chef CLA.

The following GitHub users do not appear to have signed a CLA:

Please sign the CLA here.

chef-supermarket commented Jul 16, 2014

Hi. Your friendly Curry bot here. Just letting you know that there are commit authors in this Pull Request who appear to not have signed a Chef CLA.

The following GitHub users do not appear to have signed a CLA:

Please sign the CLA here.

:host => URI(aws_profile[:iam_endpoint]).host,
:scheme => URI(aws_profile[:iam_endpoint]).scheme,
:port => URI(aws_profile[:iam_endpoint]).port,
:path => URI(aws_profile[:iam_endpoint]).path

This comment has been minimized.

@jkeiser

jkeiser Aug 18, 2014

Member

I can't figure out who uses host/scheme/port/path ... what are they used for? (It would be good to name them iam_*, too.)

@jkeiser

jkeiser Aug 18, 2014

Member

I can't figure out who uses host/scheme/port/path ... what are they used for? (It would be good to name them iam_*, too.)

This comment has been minimized.

@viglesiasce

viglesiasce Aug 18, 2014

Contributor

Those param names are what the Fog IAM connection requires:
https://github.com/fog/fog/blob/master/lib/fog/aws/iam.rb#L175

@viglesiasce

viglesiasce Aug 18, 2014

Contributor

Those param names are what the Fog IAM connection requires:
https://github.com/fog/fog/blob/master/lib/fog/aws/iam.rb#L175

@jkeiser

This comment has been minimized.

Show comment
Hide comment
@jkeiser

jkeiser Aug 18, 2014

Member

@viglesiasce I think I'm blind, I simply can't figure out what code is going to use host/scheme/port/path--I don't see any full automatic merge of aws_profile into anything. How is the IAM endpoint communicated to fog, and how does it affect things?

Member

jkeiser commented Aug 18, 2014

@viglesiasce I think I'm blind, I simply can't figure out what code is going to use host/scheme/port/path--I don't see any full automatic merge of aws_profile into anything. How is the IAM endpoint communicated to fog, and how does it affect things?

@viglesiasce

This comment has been minimized.

Show comment
Hide comment
@viglesiasce

viglesiasce Aug 18, 2014

Contributor

Hey @jkeiser!

The IAM parameters are passed as options when the Fog IAM connection is created:
https://github.com/viglesiasce/chef-metal-fog/blob/configure-endpoints/lib/chef_metal_fog/providers/aws.rb#L169

Contributor

viglesiasce commented Aug 18, 2014

Hey @jkeiser!

The IAM parameters are passed as options when the Fog IAM connection is created:
https://github.com/viglesiasce/chef-metal-fog/blob/configure-endpoints/lib/chef_metal_fog/providers/aws.rb#L169

jkeiser added a commit that referenced this pull request Aug 18, 2014

Merge pull request #34 from viglesiasce/configure-endpoints
Allow EC2/IAM endpoint configuration

@jkeiser jkeiser merged commit 647fc3d into chef:master Aug 18, 2014

@jkeiser

This comment has been minimized.

Show comment
Hide comment
@jkeiser

jkeiser Aug 18, 2014

Member

Ah, I see! OK!

Member

jkeiser commented Aug 18, 2014

Ah, I see! OK!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment