Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
RFC some changes to default behavior #135
Adding more options and toggles always seems a little fiddly to me, and as @pburkholder said, increases the amount of overhead.
It was surprising to me to read @jkeiser's example of current behavior (albiet it's not very clear how to run them, as they don't appear to work Chef 12 shell) and see the second case of
However, this pattern is not one we've typically shown in recipes before - where the attribute in a resource is passed as a value to a method, not set or changed. Unless I'm totally reading it wrong.
# what we typically do my_resource 'a' do foo 1 end # what this example shows my_resource 'a' do foo << 1 end
So are we saying that we should be setting attribute values like
@miketheman people don't presently use = to set, because it doesn't work. But I've seen (rare) cases where people use
I'm a huge fan of this, if for no reason other than validation working. :)
But are we providing a way for people who want to append to the default - or at least grab the default and then assign something based on that in? I don't personally do it, but clearly some people are doing it, or we wouldn't be here - what's the "right" way for those people?