Update deprecated syntax. #234

merged 1 commit into from Mar 10, 2014


None yet

2 participants


Per the discussion in ChefSpec: sethvargo/chefspec#368


In addition to the search(:node, "*:*") pattern, should search(:admins, "*:*") be updated to search(:admins, "*:*").each?

(found a couple topics with that pattern -- for my reference if those also need to be updated: includes_search_data_bag, includes_search_index)

@jamescott Yes. Every time we have one of these patterns of code where it reads

search(:something, 'key:value') do |blah|

the examples should always be changed to explicitly declare the iterator with .each.


@jamescott jamescott merged commit a0035db into chef:master Mar 10, 2014
@juliandunn juliandunn deleted the juliandunn:search-iterator-syntax branch Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment