Simplify message shown when WS app missing deps #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Workstation App is missing dependencies on linux, the postinst script spams the screen with a long list of missing libraries. This PR modifies the messaging to exclude the missing dependency list, and recommend installing the 'electron' app to meet them. This is not ideal, but given the constraints of omnibus (optional package dependencies are not supported) and our desire to ensure that the desktop application is included in the Workstation package, it seems a reasonable compromise. In the future, a cleaner path would be to build electron (and its deps) in the omnibus build of Workstation. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
|
Deploy preview for chef-workstation ready! Built with commit 7dc3393 |
tas50
approved these changes
Jul 9, 2020
tyler-ball
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Workstation App is missing dependencies on linux,
the postinst script spams the screen with a long list of missing
libraries.
This PR modifies the messaging to exclude the missing dependency list, and
recommend installing the 'electron' app to meet them.
This is not ideal, but given the constraints of omnibus (optional
package dependencies are not supported) and our desire to ensure that
the desktop application is included in the Workstation package,
it seems a reasonable compromise.
In the future, a cleaner path would be to build electron (and its deps) in the
omnibus build of Workstation.
Fixes #345
Signed-off-by: Marc A. Paradise marc.paradise@gmail.com
Aha! Link: https://chef.aha.io/features/SH-2542