Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstall ChefDK when installing CWS on Windows #262

Merged
merged 2 commits into from
Oct 11, 2018

Conversation

marcparadise
Copy link
Member

@marcparadise marcparadise commented Oct 11, 2018

capture

The ChefDK message page is shown before the 'Click install to proceed' page when chefdk is installed - that's the final step before any system changes are applied.
Signed-off-by: Marc A. Paradise marc.paradise@gmail.com

Check List

  • PR title is a worthy inclusion in the CHANGELOG
  • You have locally validated the change

@marcparadise marcparadise requested a review from a team October 11, 2018 04:52
@marcparadise marcparadise force-pushed the SHACK-371/uninstall-chefdk-on-windows branch 2 times, most recently from 86dd9f3 to df25703 Compare October 11, 2018 04:54
@marcparadise marcparadise force-pushed the SHACK-371/uninstall-chefdk-on-windows branch from df25703 to 92bd00c Compare October 11, 2018 15:55
Copy link
Contributor

@tyler-ball tyler-ball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo but otherwise 🚀 🍰

<WixVariable Id="WixUINewIco" Value="Resources\assets\cws_16x16.ico" />
<WixVariable Id="WixUIUpIco" Value="Resources\assets\cws_16x16.ico" />

</Product>

<!-- We copied this fragment in fromn WixUI_FeatureTsee, based on the instructions here:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: FeatureTsee -> FeatureTree

Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
@marcparadise marcparadise force-pushed the SHACK-371/uninstall-chefdk-on-windows branch from 1a13e10 to 8652fa1 Compare October 11, 2018 17:13
@marcparadise marcparadise merged commit 40d11da into master Oct 11, 2018
@chef-ci chef-ci deleted the SHACK-371/uninstall-chefdk-on-windows branch October 11, 2018 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants