Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows_security_policy: Add AuditPolicyChange and LockoutDuration capabilities #11533

Merged
merged 4 commits into from May 6, 2021

Conversation

johnmccrae
Copy link
Contributor

@johnmccrae johnmccrae commented May 6, 2021

'LockoutThreshold' is actually implemented by Windows as LockoutBadCouunt. What shows up in an Account Lockout Policy is Account Lockout Threshold but what gets written to disk when you change it is LockoutBadCount. That item is available in the list of existing policy objects. I updated the code to add AuditPolicyChange; that was missing. I also added ResetLockoutCount which pairs with the Lockout Threshold so users aren't permanently locked out. The last item, LockoutObservationWindow, does not appear in a Security Policy as exported by secedit but you can get to it via PowerShell. It is part of a customized fine grain password policy. Read more here:

Signed-off-by: John McCrae jmccrae@chef.io

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

…unt. What shows up in an Account Lockout Policy is Account Lockout Threshold but what gets written to disk when you change it is LockoutBadCount. That item is available in the list of existing policy objects. I updated the code to add AuditPolicyChange; that was mssing. I also added ResetLockoutCount which pairs with the Lockout Threshold so users aren't permanently locked out. The last item, LockoutObservationWindow, does not appear in a Security Policy as exported by secedit but you can get to it via PowerShell. It is part of a customized fine grain password policy. Read more here: http://woshub.com/fine-grained-password-policy-in-windows-server-2012-r2/

Signed-off-by: John McCrae <jmccrae@chef.io>
@johnmccrae johnmccrae requested review from a team as code owners May 6, 2021 16:47
@tas50 tas50 changed the title 'LockoutThreshold' is actually implemented by Windows as LockoutBadCo… windows_security_policy: Add AuditPolicyChange and LockoutDuration capabilities May 6, 2021
@johnmccrae johnmccrae linked an issue May 6, 2021 that may be closed by this pull request
…unt. What shows up in an Account Lockout Policy is Account Lockout Threshold but what gets written to disk when you change it is LockoutBadCount. That item is available in the list of existing policy objects. I updated the code to add AuditPolicyChange; that was mssing. I also added ResetLockoutCount which pairs with the Lockout Threshold so users aren't permanently locked out. The last item, LockoutObservationWindow, does not appear in a Security Policy as exported by secedit but you can get to it via PowerShell. It is part of a customized fine grain password policy. Read more here: http://woshub.com/fine-grained-password-policy-in-windows-server-2012-r2/

Signed-off-by: John McCrae <jmccrae@chef.io>
Signed-off-by: John McCrae <jmccrae@chef.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

windows_security_policy Resource missing policies
2 participants