New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Collector output HTTP locations become ChefServerAPI objects if a token is set #8204

Open
lamont-granquist opened this Issue Feb 5, 2019 · 2 comments

Comments

Projects
None yet
1 participant
@lamont-granquist
Copy link
Contributor

lamont-granquist commented Feb 5, 2019

This is probably not what is intended to have the DataCollector only able to send to N chef-servers or only able to send to N vanilla JSON APIs. I would assume the more common case is a user has a chef server and then has some sort of nagiabbixsu implemented that they also want to shovel data off to so would want to mix-and-match. Of course N chef-servers/reporting endpoints may be another use case so probably shouldn't totally break that at the time for anyone that is happily replicating their data right now (although I suspect the number of people doing the latter is 0 to 2 or so).

@lamont-granquist

This comment has been minimized.

Copy link
Contributor Author

lamont-granquist commented Feb 5, 2019

Should probably have output_locations just have another :chef_servers "type" to go along with :files and :urls

@lamont-granquist

This comment has been minimized.

Copy link
Contributor Author

lamont-granquist commented Feb 5, 2019

while we're in there output locations could probably take IO objects for good measure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment