Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance knife supermarket to eliminate the need for Stove #8347

Open
tas50 opened this Issue Apr 8, 2019 · 6 comments

Comments

Projects
None yet
3 participants
@tas50
Copy link
Member

commented Apr 8, 2019

I propose that we roll some of the core functionality of Stove into knife supermarket itself in order to eliminate the need for the stove command line and to make sure that everyone uploading chef cookbooks has the same experience.

Motivation

As a end user,
I want to cookbooks on the supermarket to contain a consistent set of files,
so that I don't have to worry about how a cookbook was uploaded.

As a cookbook author,
I want to knife to upload only the files necessary for a cookbook,
so that I can automate cookbook uploads without a full DK install.

As a new Chef user
I want to use knife for all interaction with Supermarket,
so that I don't have to learn another tool to be successful with Chef.

Specification

  • Knife supermarket respects the blacklist in the chefignore file when uploading cookbook to slim down the contents that gets uploaded to Supermarket to just those that are pulled down to a chef-client itself anyways.
  • A new flag allows uploading all files for those that want the artifact to match the repository contents

Downstream Impact

  • Eventually stove should go away. In the short term we'll probably want a warning that tells folks to stop using it.
@damacus

This comment has been minimized.

Copy link

commented Apr 9, 2019

Another thing that the might not be obvious is that we'd get to use the knife.rb logic, switching between accounts should be a much more plesent experience

@damacus

This comment has been minimized.

Copy link

commented Apr 9, 2019

I'm pretty sure it's been talked about before, but it would be useful to have an allowed list of files if chefignore wasn't there.

@tas50

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2019

Let me update the use case for that. Not needing yet another config file is a solid reason to use this path.

@lamont-granquist

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

What are the features of stove that are necessary, and presumably this would just be patches to knife supermarket share?

I.e. what does the actual design look like here? (and i'd argue that extending the chefignore functionality or having a default chefignore is out of scope of this issue)

@damacus

This comment has been minimized.

Copy link

commented Apr 10, 2019

Yeah, if we want bare stove functionality then it's totally scope creep

@lamont-granquist

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

Yes, this needs to be minimum viable deprecation of stove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.