Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The chef-solo binstubs need to use the Chef::Application::Client class #8366

Open
lamont-granquist opened this Issue Apr 12, 2019 · 2 comments

Comments

Projects
None yet
1 participant
@lamont-granquist
Copy link
Contributor

commented Apr 12, 2019

We really need to look at inverting the way that we invoke the Chef::Application::Solo class and then trampoline out of that into Chef::Application::Client when we are in zolo mode and not legacy chef-solo. Instead we should invoke Chef::Application::Client and then only trampoline out when we are in legacy mode, making legacy-mode the special handling case.

This means that command line parsing will have to be made consistent between the classes (and is probably a good thing -- reducing code duplication and interface drift between the two classes). The Chef::Application::Solo class should also likely have its CLI arguments removed, and all the code duplication should really get removed as much as possible.

In the end it would be best to have only Chef::Application::Client exist with special-casing around the legacy mode operation of chef-solo (although its also legacy and at some point we should deprecate that behavior, but that requires fixing the perf issues in ChefFS).

@lamont-granquist

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2019

See #8361, #8360 and #6375

@lamont-granquist

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2019

Listed as breaking change since ultimately Chef::Application::Solo going away as a class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.