Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`chocolatey_package` timeout should default to the Chocolatey `commandExecutionTimeoutSeconds` config setting #8733

Open
bender-the-greatest opened this issue Jul 10, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@bender-the-greatest
Copy link

commented Jul 10, 2019

Describe the Enhancement:

The chocolatey_package resource does not honor the commandExecutionTimeoutSeconds choco config setting, instead relying on a Chef-internal 900 second timeout by default.

Describe the Need:

Especially because we can set the client options with the chocolatey_config resource, including the commandExecutionTimeoutSeconds setting, it becomes confusing when trying to troubleshoot why your package install suddenly bombs out at 900 seconds when the default choco timeout is 2700 seconds, and recommended to be 14400 for enterprises.

Current Alternative

Set timeout on all chocolatey_package resources. This seems redundant though when we have set a client default.

Can We Help You Implement This?:

If this is met positively I would love to take a crack at implementing this.

@lamont-granquist

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

yeah you can give that a shot, the way it picks up the timeout value from shell_out is a bit magical, and you need to not affect any global behavior and keep the changes isolated to the chocolatey package resource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.