Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knife cookbook upload and probably knife upload cookbook do not validate presence of metadata.json/metadata.rb or validate important fields exist #9003

Open
lamont-granquist opened this issue Oct 17, 2019 · 0 comments

Comments

@lamont-granquist
Copy link
Contributor

@lamont-granquist lamont-granquist commented Oct 17, 2019

The way knife cookbook upload/upload cookbooks should behave is:

  1. use the metadata.json if present
  2. use the metadata.rb if present (generate the metadata.json)
  3. raise if none of them are present
  4. validate the name field was parsed from the metadata (throw if not)
  5. validate the version field was parsed from the metadata (throw if not)

right now a cookbook without any metadata can be uploaded to a chef-zero server and will get a name of null and a version of "0.0.0". the chef-server fails validation on the metadata.name being null, but we should catch that client-side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.