Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap node['platform_version'] in a Chef::VersionString #9154

Open
lamont-granquist opened this issue Dec 10, 2019 · 0 comments
Open

Wrap node['platform_version'] in a Chef::VersionString #9154

lamont-granquist opened this issue Dec 10, 2019 · 0 comments

Comments

@lamont-granquist
Copy link
Contributor

@lamont-granquist lamont-granquist commented Dec 10, 2019

Inflate it into a Chef::VersionString after its read in from ohai and that will allow:

node['platform_version'] > 6.10 to just work correctly without the inherent bugginess of to_f.

backport it to 14/15, then consider raising on to_i/to_f in Chef::VersionString and force people off of those poor APIs.

for bonus points get Chef::VersionString into chef-utils and use it in ohai so that you can do the same there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Chef 16
  
To do
2 participants
You can’t perform that action at this time.