Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should copy some of the property_types from the docker cookbook into core (Boolean) #9170

Open
lamont-granquist opened this issue Dec 16, 2019 · 0 comments

Comments

@lamont-granquist
Copy link
Contributor

@lamont-granquist lamont-granquist commented Dec 16, 2019

Heh they've already been deleted there. Some of them are terrible but Boolean at least would be useful:

https://github.com/chef-cookbooks/docker/blob/f5cb21656f7d5608cb8ca0af888325a2481d4a71/libraries/docker_base.rb#L44-L47

Need to audit how the property_type API works and how Boolean is wired up and make sure that isn't going to cause issues if e.g. ruby introduces a Boolean class into core. Some more thought needs to go into it than just copying the code into core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Chef 16
  
To do
1 participant
You can’t perform that action at this time.