Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove highline gem #9359

Open
reedlaw opened this issue Feb 10, 2020 · 2 comments
Open

Remove highline gem #9359

reedlaw opened this issue Feb 10, 2020 · 2 comments

Comments

@reedlaw
Copy link

@reedlaw reedlaw commented Feb 10, 2020

Describe the Enhancement:

Highline dependency is too restrictive.

Describe the Need:

It prevents other gems from being updated.

Current Alternative

#8381 already supplied the alternative

Can We Help You Implement This?:

From searching the code it doesn't seem like highline is being used at all. It could be as simple as removing the gem and unused methods.

@tas50

This comment has been minimized.

Copy link
Member

@tas50 tas50 commented Feb 10, 2020

@reedlaw There's a few other places we use highline that need to get updated to use the tty gems. #8381 was the first part of this work, but it was also the easy part.

@lamont-granquist

This comment has been minimized.

Copy link
Contributor

@lamont-granquist lamont-granquist commented Feb 11, 2020

./lib/chef/knife/core/ui.rb and ./lib/chef/formatters/indentable_output_stream.rb still use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.