Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add system_name property to rhsm_register resource #10413

Merged
merged 1 commit into from Sep 10, 2020
Merged

Add system_name property to rhsm_register resource #10413

merged 1 commit into from Sep 10, 2020

Conversation

jasonwbarnett
Copy link
Contributor

Description

This change allows specifying an alternative name when registering the node.

Related Issue

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@jasonwbarnett jasonwbarnett requested review from a team as code owners September 10, 2020 16:00
@tas50
Copy link
Contributor

tas50 commented Sep 10, 2020

@jasonwbarnett You have some invalid ruby in there

@jasonwbarnett
Add system_name property to rhsm_register resource
6fdb6d1 
Signed-off-by: Jason Barnett <jason.w.barnett@gmail.com>
@jasonwbarnett jasonwbarnett force-pushed the feature/add-name-to-rhsm_register branch from 30cabdc to 6fdb6d1 Compare September 10, 2020 16:27
@jasonwbarnett
Copy link
Contributor Author

jasonwbarnett commented Sep 10, 2020 •
edited

@jasonwbarnett You have some invalid ruby in there

@tas50 woah, nice catch! Let's try that again 😄

@tas50 tas50 merged commit 2102707 into chef:master Sep 10, 2020
@tas50
Copy link
Contributor

tas50 commented Sep 10, 2020

Looks good. Thanks

@jasonwbarnett jasonwbarnett deleted the feature/add-name-to-rhsm_register branch September 10, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jasonwbarnett @tas50