Fix idempotency issues in build_essential on the mac #10647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 issues this solves: - On some systems the Command Line Tools aren't showing up in the install history plist we're parsing. This means we attempt to install the tools each time chef runs, which takes a LONG time even on a top of the line mac. It was suggested in mac admins slack to just use xcode-select -p which lists the command line tools path or exits 2 if not installed. - When the :upgrade action is used we were parsing out the software update list twice for no reason, which made it take even longer. Signed-off-by: Tim Smith <tsmith@chef.io>
There's really no point in testing this method now since it would be us mocking out junk only. Signed-off-by: Tim Smith <tsmith@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 issues this solves:
On some systems the Command Line Tools aren't showing up in the install history plist we're parsing. This means we attempt to install the tools each time chef runs, which takes a LONG time even on a top of the line mac. It was suggested in mac admins slack to just use xcode-select -p which lists the command line tools path or exits 2 if not installed.
When the :upgrade action is used we were parsing out the software update list twice for no reason, which made it take even longer.
Signed-off-by: Tim Smith tsmith@chef.io