New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chef::VersionConstraint#to_s should accurately reflect the constraint's behavior #1638

Merged
merged 3 commits into from Aug 7, 2014

Conversation

Projects
None yet
5 participants
@bcobb
Contributor

bcobb commented Jul 14, 2014

For example, Chef::VersionConstraint.new('~> 1.2').to_s is now "~> 1.2" instead of "~> 1.2.0".
#848 introduced a change to Chef::Cookbook::Metadata to correct for the behavior of Chef::VersionConstraint#to_s when the constraint does not specify a patch level. This PR moves that change to the Chef::VersionConstraint#to_s and Chef::VersionConstraint#inspect methods so that the String representations of version constraints match their behavior.

@bcobb bcobb added the Signed CLA label Jul 14, 2014

@sersut sersut added the Bug label Jul 15, 2014

@btm

This comment has been minimized.

Member

btm commented Jul 30, 2014

👍

@btm btm added the Ready for Merge label Jul 30, 2014

@sersut sersut added the Chef Core label Aug 6, 2014

mcquin added a commit that referenced this pull request Aug 7, 2014

Merge pull request #1638 from bcobb/version-constraint-string-reflect…
…s-behavior

Chef::VersionConstraint#to_s should accurately reflect the constraint's behavior

@mcquin mcquin merged commit 5453d55 into chef:master Aug 7, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@bcobb bcobb deleted the bcobb:version-constraint-string-reflects-behavior branch Aug 8, 2014

@chef chef locked and limited conversation to collaborators Nov 16, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.