Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Chef 1251 #256

Closed
wants to merge 105 commits into from
@aglarond

Fixed both cases (for installing from a local file as well as from a remote site) when no ports tree is present.

@mrtazz

This has bitten me especially on smaller VPS where I don't want to waste disk space on checking out the complete ports tree.

vgirnet and others added some commits
@vgirnet vgirnet CHEF-2972 - EPEL rpm repository hostname changed 23946a7
@juanje juanje [CHEF-2976] Add support to 'knife node run_list remove' to remove a l…
…ist of items
39a54bf
trevoro TOOLS-98 Chef needs pkgin specific plugins aeaa465
trevoro TOOLS-98 Adding smartos spec tests 50cb217
trevoro [CHEF-2989] removing smartos cron 02fb193
trevoro [CHEF-2989] Switching to "shell_out" 9bea9ef
@btm btm CHEF-3014: pin rspec < 2.9.0 84b31de
@mitchellh mitchellh CHEF-2935: Add metadata option to the mdadm resource 13e4cd9
@akzhan akzhan [CHEF-2956] Update gemspec to use latest RSpec eeecc81
@akzhan akzhan We need Rack and Thin for Chef specs 372271a
@andruby andruby Fix git clone for destinations with spaces 75706ee
@andruby andruby Use Shellwords.escape to cleanly escape destination 5d33763
@juanje juanje [CHEF-2968] Fix 'knife run_list add' to expect list of RunListItems d286b85
@lusis lusis adding keys_only opt to knife ssh dbfcbe5
@buysse buysse Patch for CHEF-2970, include_recipe not correctly detecting that
a recipe is already included due to confusion between "cookbook" and
"cookbook::default".
0ce0413
trevoro Removing smartos specific service ef2889b
trevoro Reverting cookbook_loader_spec change 05ee476
@ktheory ktheory Fix undefined Chef::Log when using rest client 1916d2e
@ktheory ktheory Fix nil Chef::Config when using rest client 741d4e8
@mdkent mdkent CHEF-2801: Don't update version constraints when a cookbook upload
fails due to a cookbook being frozen.
09a4a67
@mleinart mleinart CHEF-2881: add 'run' command to init scripts
'run' command will send a SIGUSR1, triggering a chef run on a daemonized
instance
3f8d56d
@thbishop thbishop [CHEF-2927] Setup support for chef-solr specs 374d47c
@thbishop thbishop [CHEF-2927] Specs for chef solr application 719f4d2
@thbishop thbishop [CHEF-2927] Warn if the maxFieldLength is too low during chef-solr st…
…artup
8b1f770
John Goulah add load_recipe method to separate logic from include_recipe 5deec34
@akzhan akzhan [CHEF-2852] Knife:SSH specification never executed before and has fai…
…lures.
08809b9
@akzhan akzhan Allow to assign frozen strings like ENV variables to ssh_user and ssh…
…_identity_file parameters of Knife configuration file.
5a42958
@iafonov iafonov Added environment to cron resource. 9853935
@iafonov iafonov Custom variables support in cron provider. 10194fd
@iafonov iafonov Custom variables support in solaris cron provider. 472dcf1
@mdkent mdkent CHEF-2781: We don't need to worry about the frozen state of a cookbook
if it's new. Add specs to validate some basic logic in the controller.
d6f3333
@mdkent mdkent CHEF-2801: Only update the environment when necessary. 2f41c14
@mdkent mdkent CHEF-2801: Provide better feedback as to success and failure in knife
cookbook uploads to avoid the confusion of failures with "upload
complete".
a4ecbe7
@mdkent mdkent CHEF-2801: Exit immediately if we have nothing to do, especially before
loading content from the server.
cccce27
@mdkent mdkent CHEF-2801: Add some basic specs for cookbook uploads which include
recent behaviour and output modifications.
5a79bcc
@mdkent mdkent CHEF-2488: Handle periods in dpkg names as they are allowed by the spec. 2efe02a
@hh hh modifed ssh_attribute to function similar to ssh_port in knife.rb config f290959
@juanje juanje [CHEF-2740] Add new public method to file_edit.rb to append a line if…
… the regex doesn't match
5493111
@juanje juanje add rspec tests for the new method at Chef::Util::FileEdit 1257309
@maxrabin maxrabin remove default value because the default is provided in the configure…
…_attribute function
f52cc44
@stevendanna stevendanna CHEF-2896: Ensure DoppelGangerClient expands runlist when building node 7acfa2d
@thbishop thbishop [CHEF-2919] Add specs for knife cookbook site download d4eb9d1
@thbishop thbishop [CHEF-2919] Refactor knife cookbook site download 5494dda
@thbishop thbishop [CHEF-2919] Require fileutils in knife cookbook site download 1e04842
@iafonov iafonov Whitelist cron provider variables instead of direct invocation a57155f
@iafonov iafonov Use inherited methods in solaris cron provider. 0aeeb34
@mdkent mdkent CHEF-2328: Stop some rubygems deprecation warnings by using current
methods when appropriate. Tested on rubygems 1.3.7, 1.6.2 and 1.8.12.
81017db
@thbishop thbishop [CHEF-2690] Handle command timeout in conditional resource
'only_if' convergence should not continue
'not_if' convergence should continue
db54f9b
@thbishop thbishop [CHEF-2690] Log warning when a command times out in conditional b2552f2
Max Horbul expand install path so I can set/provide relative path to cookbooks i…
…n ~/.chef/knife.rb or from the CLI via -o option
06ad87d
Max Horbul take the argument of the shell command into the quotes to avoid error…
…s when the path has spaces
fd08067
@llaurent llaurent remote_directory: prevent rmdir of non-empty directories 7336010
@llaurent llaurent CHEF-2599: adding a test case to reproduce the bug ff83d27
@llaurent llaurent use of ::File instead of File a618f68
@juanje juanje [CHEF-1398] Add check for bad RunListItems
Added check for RunListItems non role or recipe format compilant.
Thanks to Bryan McLellan for simplify the regrex and for adding
a new user case test.
83dd8d9
@theturtle32 theturtle32 Resolving bug CHEF-1828: Git provider should recursively update/init …
…submodules
f979cb6
@abecciu abecciu added option for ssh gateway in knife ssh command. c4ae39b
@abecciu abecciu added ssh gateway option to knife bootstrap command. b656a8f
@jdonagher jdonagher add support for ssh_gateway definition in knife.rb 1442f80
@vlcek vlcek Add default release option for apt package provider. Fixes #CHEF-1547 25fd12a
@stevendanna stevendanna CHEF-2512: Validate site install arguments and add basic tests. cf9bbee
@stevendanna stevendanna CHEF-2512: More tests. 9aa7efd
@btm btm CHEF-1547: test fix, set_or_return does not create an = method c936e41
@btm btm CHEF-1827: update the tests 31142dc
@btm btm CHEF-1827: We now require Git 1.6.5+ fa5319e
@douglaswth douglaswth Fix the rubygems provider when gem_binary is specified and source is …
…a local file.
c91a081
@douglaswth douglaswth Make gem file name check case insensitive. 79bd1ed
@stevendanna stevendanna Improve tests 27abdeb
@douglaswth douglaswth Add unit tests for installing a gem file with an alternate gem enviro…
…nment.
62b6184
@kovyrin kovyrin Fix platform detection in route provider so that it works on all redh…
…at systems, not only centos
da5f57e
@stevendanna stevendanna Refactor cookbook_upload, fixing CHEF-2543.
This commit extracts the logic to determine which cookbooks to upload
into its own method, simplifying the main run method.  As a side
effect, this also solves CHEF-2543.

The commit also includes basic tests for this method; however, the
tests do not yet provide full coverage.

Conflicts:

	chef/lib/chef/knife/cookbook_upload.rb
	chef/spec/unit/knife/cookbook_upload_spec.rb
5b72aee
@btm btm Remove thin from development dependencies until eventmachine stable s…
…upports Ruby 1.9 on Windows
84f64a7
@btm btm update tests for knife cookbook site install on windows 1fd50b4
@btm btm CHEF-3003: Test that we're writing to the correct place and that we l…
…og as much
e088f9b
@btm btm fix quoting for 'knife cookbook site install' tests on windows 6af4b5c
@kovyrin kovyrin Fix route provider to write all routes to route configuration files o…
…n redhat (previously only the last defined route would be written)
99bc624
@btm btm CHEF-3008: Add tests for route file content bcdbb22
@btm btm knife CSD version must be accessible to knife CSI 2bbe7ea
@btm btm require shellwords for use in 5588b9e d519779
@btm btm Chef 0.10.10.beta.1 bf77e78
@alext alext Refactored cron provider unit tests. a4e7558
@alext alext CHEF-1681 Handle commented out cron entries cd874d0
@alext alext Rename Chef::Provider::Cron.compare_cron method to cron_different?
This better reflects what the method does.
81ab75d
@alext alext CHEF-1681 Ported standard cron provider behaviour to Solaris cron pro…
…vider.
d3fd590
@andreacampi andreacampi [CHEF-2964] Pass the "fast" flag to rc scripts to disable any pre-fli…
…ght checks on whether the service is already started.
9340a92
@andreacampi andreacampi [CHEF-2964] Specs for overridden methods in the freebsd service provi…
…der.

I kept the code as similar as possible to init_service_spec.rb, even though there a few things that could/should be improved.
daa4a8c
@andreacampi andreacampi [CHEF-2964] Convert the freebsd service provider to Mixlib ShellOut. d0e2906
@andreacampi andreacampi [CHEF-2964] Convert the base service providers to Mixlib ShellOut. fb4ce9e
@andreacampi andreacampi [CHEF-2964] Make the freebsd service provider more DRY by factoring o…
…ut most of load_current_resource.
6253388
@andreacampi andreacampi [CHEF-2964] Update invokercd specs, affected by the Simple service pr…
…ovider

moving to shell_out.
f48e8a9
@alext alext Refactored cron provider to have private methods for reading and writ…
…ing the crontab

This will facilitate subcalssing.
0b92e28
@alext alext CHEF-1681 Refactored Solaris Cron provider to inherit most of its fun…
…ctionality form the generic provider
ec39b08
@alext alext Fix indentation 2d0d6f2
@alext alext CHEF-2745 Fix issue with generic environment variables that match int…
…ernals
1e8ada8
@j3p0uk j3p0uk 3rd part of fix for CHEF-1747
Need to ensure files will be returned
92a8758
@j3p0uk j3p0uk Update tests to verify CHEF-1747 5a1b510
@andreacampi andreacampi [CHEF-2964] Update Macosx specs, affected by the Simple service provider
moving to shell_out.
05a29df
@andreacampi andreacampi [CHEF-2964] Update mocking in a spec, affected by the Simple service …
…provider moving to shell_out.
9ef1d6b
@j3p0uk j3p0uk Update to most appropriate regex for cookbook version 82e8202
@aglarond aglarond [CHEF-1251] removed rescue conditionals 3c1c6db
@aglarond aglarond [CHEF-1251] hardcoded existence check to /usr/ports/Makefile 542eeb1
@aglarond aglarond [CHEF-1251] fixed file_candidate_version_path to give the latest vers…
…ion when there are multiple versions present
09883fc
@aglarond aglarond [CHEF-1251] corrected load_current_resource to prevent regression 97bf957
@btm
Owner

merged to master.

@btm btm closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 23, 2012
  1. @aglarond

    [CHEF-1251] fixed for the case that the binary package and its depend…

    aglarond authored
    …encies are available locally under the :source
  2. @aglarond
Commits on Apr 11, 2012
  1. @vgirnet @aglarond

    CHEF-2972 - EPEL rpm repository hostname changed

    vgirnet authored aglarond committed
  2. @juanje @aglarond

    [CHEF-2976] Add support to 'knife node run_list remove' to remove a l…

    juanje authored aglarond committed
    …ist of items
  3. @aglarond

    TOOLS-98 Chef needs pkgin specific plugins

    trevoro authored aglarond committed
  4. @aglarond

    TOOLS-98 Adding smartos spec tests

    trevoro authored aglarond committed
  5. @aglarond

    [CHEF-2989] removing smartos cron

    trevoro authored aglarond committed
  6. @aglarond

    [CHEF-2989] Switching to "shell_out"

    trevoro authored aglarond committed
  7. @btm @aglarond

    CHEF-3014: pin rspec < 2.9.0

    btm authored aglarond committed
  8. @mitchellh @aglarond

    CHEF-2935: Add metadata option to the mdadm resource

    mitchellh authored aglarond committed
  9. @akzhan @aglarond

    [CHEF-2956] Update gemspec to use latest RSpec

    akzhan authored aglarond committed
  10. @akzhan @aglarond

    We need Rack and Thin for Chef specs

    akzhan authored aglarond committed
  11. @andruby @aglarond

    Fix git clone for destinations with spaces

    andruby authored aglarond committed
  12. @andruby @aglarond

    Use Shellwords.escape to cleanly escape destination

    andruby authored aglarond committed
  13. @juanje @aglarond
  14. @lusis @aglarond

    adding keys_only opt to knife ssh

    lusis authored aglarond committed
  15. @buysse @aglarond

    Patch for CHEF-2970, include_recipe not correctly detecting that

    buysse authored aglarond committed
    a recipe is already included due to confusion between "cookbook" and
    "cookbook::default".
  16. @aglarond

    Removing smartos specific service

    trevoro authored aglarond committed
  17. @aglarond

    Reverting cookbook_loader_spec change

    trevoro authored aglarond committed
  18. @ktheory @aglarond

    Fix undefined Chef::Log when using rest client

    ktheory authored aglarond committed
  19. @ktheory @aglarond

    Fix nil Chef::Config when using rest client

    ktheory authored aglarond committed
  20. @mdkent @aglarond

    CHEF-2801: Don't update version constraints when a cookbook upload

    mdkent authored aglarond committed
    fails due to a cookbook being frozen.
  21. @mleinart @aglarond

    CHEF-2881: add 'run' command to init scripts

    mleinart authored aglarond committed
    'run' command will send a SIGUSR1, triggering a chef run on a daemonized
    instance
  22. @thbishop @aglarond

    [CHEF-2927] Setup support for chef-solr specs

    thbishop authored aglarond committed
  23. @thbishop @aglarond

    [CHEF-2927] Specs for chef solr application

    thbishop authored aglarond committed
  24. @thbishop @aglarond
  25. @aglarond

    add load_recipe method to separate logic from include_recipe

    John Goulah authored aglarond committed
  26. @akzhan @aglarond
  27. @akzhan @aglarond

    Allow to assign frozen strings like ENV variables to ssh_user and ssh…

    akzhan authored aglarond committed
    …_identity_file parameters of Knife configuration file.
  28. @iafonov @aglarond

    Added environment to cron resource.

    iafonov authored aglarond committed
  29. @iafonov @aglarond

    Custom variables support in cron provider.

    iafonov authored aglarond committed
  30. @iafonov @aglarond

    Custom variables support in solaris cron provider.

    iafonov authored aglarond committed
  31. @mdkent @aglarond

    CHEF-2781: We don't need to worry about the frozen state of a cookbook

    mdkent authored aglarond committed
    if it's new. Add specs to validate some basic logic in the controller.
  32. @mdkent @aglarond

    CHEF-2801: Only update the environment when necessary.

    mdkent authored aglarond committed
  33. @mdkent @aglarond

    CHEF-2801: Provide better feedback as to success and failure in knife

    mdkent authored aglarond committed
    cookbook uploads to avoid the confusion of failures with "upload
    complete".
  34. @mdkent @aglarond

    CHEF-2801: Exit immediately if we have nothing to do, especially before

    mdkent authored aglarond committed
    loading content from the server.
  35. @mdkent @aglarond

    CHEF-2801: Add some basic specs for cookbook uploads which include

    mdkent authored aglarond committed
    recent behaviour and output modifications.
  36. @mdkent @aglarond
  37. @hh @aglarond
  38. @juanje @aglarond

    [CHEF-2740] Add new public method to file_edit.rb to append a line if…

    juanje authored aglarond committed
    … the regex doesn't match
  39. @juanje @aglarond

    add rspec tests for the new method at Chef::Util::FileEdit

    juanje authored aglarond committed
  40. @maxrabin @aglarond

    remove default value because the default is provided in the configure…

    maxrabin authored aglarond committed
    …_attribute function
  41. @stevendanna @aglarond
  42. @thbishop @aglarond

    [CHEF-2919] Add specs for knife cookbook site download

    thbishop authored aglarond committed
  43. @thbishop @aglarond

    [CHEF-2919] Refactor knife cookbook site download

    thbishop authored aglarond committed
  44. @thbishop @aglarond
  45. @iafonov @aglarond
  46. @iafonov @aglarond

    Use inherited methods in solaris cron provider.

    iafonov authored aglarond committed
  47. @mdkent @aglarond

    CHEF-2328: Stop some rubygems deprecation warnings by using current

    mdkent authored aglarond committed
    methods when appropriate. Tested on rubygems 1.3.7, 1.6.2 and 1.8.12.
  48. @thbishop @aglarond

    [CHEF-2690] Handle command timeout in conditional resource

    thbishop authored aglarond committed
    'only_if' convergence should not continue
    'not_if' convergence should continue
  49. @thbishop @aglarond
  50. @aglarond

    expand install path so I can set/provide relative path to cookbooks i…

    Max Horbul authored aglarond committed
    …n ~/.chef/knife.rb or from the CLI via -o option
  51. @aglarond

    take the argument of the shell command into the quotes to avoid error…

    Max Horbul authored aglarond committed
    …s when the path has spaces
  52. @llaurent @aglarond

    remote_directory: prevent rmdir of non-empty directories

    llaurent authored aglarond committed
  53. @llaurent @aglarond

    CHEF-2599: adding a test case to reproduce the bug

    llaurent authored aglarond committed
  54. @llaurent @aglarond

    use of ::File instead of File

    llaurent authored aglarond committed
  55. @juanje @aglarond

    [CHEF-1398] Add check for bad RunListItems

    juanje authored aglarond committed
    Added check for RunListItems non role or recipe format compilant.
    Thanks to Bryan McLellan for simplify the regrex and for adding
    a new user case test.
  56. @theturtle32 @aglarond

    Resolving bug CHEF-1828: Git provider should recursively update/init …

    theturtle32 authored aglarond committed
    …submodules
  57. @abecciu @aglarond

    added option for ssh gateway in knife ssh command.

    abecciu authored aglarond committed
  58. @abecciu @aglarond

    added ssh gateway option to knife bootstrap command.

    abecciu authored aglarond committed
  59. @jdonagher @aglarond

    add support for ssh_gateway definition in knife.rb

    jdonagher authored aglarond committed
  60. @vlcek @aglarond
  61. @stevendanna @aglarond
  62. @stevendanna @aglarond

    CHEF-2512: More tests.

    stevendanna authored aglarond committed
  63. @btm @aglarond
  64. @btm @aglarond

    CHEF-1827: update the tests

    btm authored aglarond committed
  65. @btm @aglarond

    CHEF-1827: We now require Git 1.6.5+

    btm authored aglarond committed
  66. @douglaswth @aglarond

    Fix the rubygems provider when gem_binary is specified and source is …

    douglaswth authored aglarond committed
    …a local file.
  67. @douglaswth @aglarond

    Make gem file name check case insensitive.

    douglaswth authored aglarond committed
  68. @stevendanna @aglarond

    Improve tests

    stevendanna authored aglarond committed
  69. @douglaswth @aglarond
  70. @kovyrin @aglarond

    Fix platform detection in route provider so that it works on all redh…

    kovyrin authored aglarond committed
    …at systems, not only centos
  71. @stevendanna @aglarond

    Refactor cookbook_upload, fixing CHEF-2543.

    stevendanna authored aglarond committed
    This commit extracts the logic to determine which cookbooks to upload
    into its own method, simplifying the main run method.  As a side
    effect, this also solves CHEF-2543.
    
    The commit also includes basic tests for this method; however, the
    tests do not yet provide full coverage.
    
    Conflicts:
    
    	chef/lib/chef/knife/cookbook_upload.rb
    	chef/spec/unit/knife/cookbook_upload_spec.rb
  72. @btm @aglarond

    Remove thin from development dependencies until eventmachine stable s…

    btm authored aglarond committed
    …upports Ruby 1.9 on Windows
  73. @btm @aglarond

    update tests for knife cookbook site install on windows

    btm authored aglarond committed
  74. @btm @aglarond

    CHEF-3003: Test that we're writing to the correct place and that we l…

    btm authored aglarond committed
    …og as much
  75. @btm @aglarond
  76. @kovyrin @aglarond

    Fix route provider to write all routes to route configuration files o…

    kovyrin authored aglarond committed
    …n redhat (previously only the last defined route would be written)
  77. @btm @aglarond

    CHEF-3008: Add tests for route file content

    btm authored aglarond committed
  78. @btm @aglarond

    knife CSD version must be accessible to knife CSI

    btm authored aglarond committed
  79. @btm @aglarond

    require shellwords for use in 5588b9e

    btm authored aglarond committed
  80. @btm @aglarond

    Chef 0.10.10.beta.1

    btm authored aglarond committed
  81. @alext @aglarond

    Refactored cron provider unit tests.

    alext authored aglarond committed
  82. @alext @aglarond

    CHEF-1681 Handle commented out cron entries

    alext authored aglarond committed
  83. @alext @aglarond

    Rename Chef::Provider::Cron.compare_cron method to cron_different?

    alext authored aglarond committed
    This better reflects what the method does.
  84. @alext @aglarond

    CHEF-1681 Ported standard cron provider behaviour to Solaris cron pro…

    alext authored aglarond committed
    …vider.
  85. @andreacampi @aglarond

    [CHEF-2964] Pass the "fast" flag to rc scripts to disable any pre-fli…

    andreacampi authored aglarond committed
    …ght checks on whether the service is already started.
  86. @andreacampi @aglarond

    [CHEF-2964] Specs for overridden methods in the freebsd service provi…

    andreacampi authored aglarond committed
    …der.
    
    I kept the code as similar as possible to init_service_spec.rb, even though there a few things that could/should be improved.
  87. @andreacampi @aglarond
  88. @andreacampi @aglarond
  89. @andreacampi @aglarond

    [CHEF-2964] Make the freebsd service provider more DRY by factoring o…

    andreacampi authored aglarond committed
    …ut most of load_current_resource.
  90. @andreacampi @aglarond

    [CHEF-2964] Update invokercd specs, affected by the Simple service pr…

    andreacampi authored aglarond committed
    …ovider
    
    moving to shell_out.
  91. @alext @aglarond

    Refactored cron provider to have private methods for reading and writ…

    alext authored aglarond committed
    …ing the crontab
    
    This will facilitate subcalssing.
  92. @alext @aglarond

    CHEF-1681 Refactored Solaris Cron provider to inherit most of its fun…

    alext authored aglarond committed
    …ctionality form the generic provider
  93. @alext @aglarond

    Fix indentation

    alext authored aglarond committed
  94. @alext @aglarond

    CHEF-2745 Fix issue with generic environment variables that match int…

    alext authored aglarond committed
    …ernals
  95. @j3p0uk @aglarond

    3rd part of fix for CHEF-1747

    j3p0uk authored aglarond committed
    Need to ensure files will be returned
  96. @j3p0uk @aglarond

    Update tests to verify CHEF-1747

    j3p0uk authored aglarond committed
  97. @andreacampi @aglarond

    [CHEF-2964] Update Macosx specs, affected by the Simple service provider

    andreacampi authored aglarond committed
    moving to shell_out.
  98. @andreacampi @aglarond

    [CHEF-2964] Update mocking in a spec, affected by the Simple service …

    andreacampi authored aglarond committed
    …provider moving to shell_out.
  99. @j3p0uk @aglarond

    Update to most appropriate regex for cookbook version

    j3p0uk authored aglarond committed
  100. @aglarond
  101. @aglarond
  102. @aglarond

    [CHEF-1251] fixed file_candidate_version_path to give the latest vers…

    aglarond authored
    …ion when there are multiple versions present
Commits on Apr 26, 2012
  1. @aglarond
Something went wrong with that request. Please try again.