Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent creation of data bags named node, role, client or environment #6469

Merged
merged 2 commits into from Oct 5, 2017

Conversation

sandratiffin
Copy link
Contributor

@sandratiffin sandratiffin commented Oct 3, 2017

…ment.

Signed-off-by: Sandra Tiffin sandi.tiffin@gmail.com

Description

Prevent creation of data bags named node, role, client or environment, using knife.

Issues Resolved

#3058

Check List

@sandratiffin sandratiffin requested a review from a team October 3, 2017 22:02
Copy link
Contributor

@thommay thommay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@coderanger
Copy link
Contributor

@sanditiffin is also adding this on the ChefFS paths.

@coderanger
Copy link
Contributor

Never mind on the ChefFS bits, we couldn't figure out how to make that work. Merge ready once Travis is less sad at life.

@sandratiffin
Copy link
Contributor Author

sandratiffin commented Oct 4, 2017

I have updated this PR to also include the ChefFS fix. I also have a related web docs fix for which I will be submitting a PR.

…ment.

Signed-off-by: Sandra Tiffin <sandi.tiffin@gmail.com>
…ment via 'knife upload'.

(Fixes the ChefFS code path for data bag creation, for chef#3058).

Signed-off-by: Sandra Tiffin <sandi.tiffin@gmail.com>
@thommay thommay merged commit 880fc13 into chef:master Oct 5, 2017
@thommay
Copy link
Contributor

thommay commented Oct 5, 2017

Thanks, @sanditiffin!

@chef chef locked and limited conversation to collaborators Feb 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants