Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammar fixes in windows_task #6828

Merged
merged 3 commits into from Feb 7, 2018
Merged

Grammar fixes in windows_task #6828

merged 3 commits into from Feb 7, 2018

Conversation

Happycoil
Copy link
Contributor

Signed-off-by: Tor Magnus Rakvåg tm@intility.no

Description

Fixes some minor grammar nits in windows_task

Check List

plural to singular, consistent use of contractions
81dcf59 
Signed-off-by: Tor Magnus Rakvåg <tm@intility.no>
@Happycoil Happycoil requested a review from a team February 6, 2018 16:10
@Happycoil
Copy link
Contributor Author

Okay, I'll flip all the contractions around. It occurs to me that there might be a lot of them in other files though...

@stuartpreston
Copy link

Agreed! We definitely need to do a sweep. Thanks for the effort!

Tor Magnus Rakvåg added 2 commits February 7, 2018 09:57
remove contractions
4bc3197 
Signed-off-by: Tor Magnus Rakvåg tm@intility.no
remove punctuation for consistency
01a8b2d 
Signed-off-by: Tor Magnus Rakvåg tm@intility.no
@Happycoil
Copy link
Contributor Author

I fixed the missing DCOs.

@thommay thommay added Expeditor: Skip Build Expeditor: Skip Version Bump Used to skip built_in:bump_version labels Feb 7, 2018
@thommay thommay merged commit 312c99f into chef:master Feb 7, 2018
chef-ci pushed a commit that referenced this pull request Feb 7, 2018
Update CHANGELOG.md with details from pull request #6828
e263467
@Happycoil Happycoil deleted the windows_task_warning_fix branch February 7, 2018 13:25
@lock
Copy link

lock bot commented Apr 14, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Apr 14, 2018
@tas50 tas50 added Expeditor: Skip Omnibus Used to skip built_in:trigger_omnibus_release_build and removed Expeditor: Skip Build labels Jan 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thommay thommay thommay approved these changes

@tas50 tas50 tas50 approved these changes

Assignees
No one assigned
Labels
Expeditor: Skip Omnibus Used to skip built_in:trigger_omnibus_release_build Expeditor: Skip Version Bump Used to skip built_in:bump_version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Happycoil @stuartpreston @thommay @tas50