Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHACK-304] Deprecation checking turns up false positive #7515

Merged
merged 1 commit into from Jul 31, 2018

Conversation

@tyler-ball
Copy link
Member

commented Jul 31, 2018

Description

When the location string during a deprecation check looks like
/opt/chefdk/embedded/lib/ruby/gems/2.5.0/gems/chef-14.3.37/spec/unit/chef_class_spec.rb:141:in 'block (4 levels) in <top (required)>' then trying to silence
deprecation warnings using only an index number (EG,
Chef::Config[:silence_deprecation_warnings] = [0]) can end up matching
part of that location string incorrectly. In this case it matched the 0
in the ruby version.

Issues Resolved

SHACK-304

Check List

Signed-off-by: tyler-ball tball@chef.io

When the location string during a deprecation check looks like
"/opt/chefdk/embedded/lib/ruby/gems/2.5.0/gems/chef-14.3.37/spec/unit/chef_class_spec.rb:141:in
`block (4 levels) in <top (required)>'" then trying to catch silence
deprecation warnings using only an index number (EG,
"Chef::Config[:silence_deprecation_warnings] = [0]") can end up matching
part of that location string incorrectly. In this case it matched the 0
in the ruby version.

Signed-off-by: tyler-ball <tball@chef.io>
@tyler-ball tyler-ball requested review from coderanger and Jul 31, 2018
@tyler-ball tyler-ball merged commit 399249e into master Jul 31, 2018
5 checks passed
5 checks passed
DCO This commit has a DCO Signed-off-by
Details
codecov/patch Coverage not affected when comparing 94a4b1c...50189c9
Details
codecov/project 86.61% remains the same compared to 94a4b1c
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tyler-ball tyler-ball deleted the SHACK-304/numbers_are_hard branch Jul 31, 2018
tyler-ball added a commit to chef/chef-dk that referenced this pull request Aug 1, 2018
To take advantage of chef/chef#7515 and fix the
build pipeline

Signed-off-by: tyler-ball <tball@chef.io>
@tyler-ball tyler-ball referenced this pull request Aug 1, 2018
0 of 4 tasks complete
tyler-ball added a commit to chef/chef-dk that referenced this pull request Aug 1, 2018
As soon as Chef 14.4 is released and we can consume it we can uncomment
these. Chef 14.4 contains chef/chef#7515 which
fixes these tests.

Signed-off-by: tyler-ball <tball@chef.io>
@lock

This comment has been minimized.

Copy link

commented Sep 29, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.