New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dist windows powershell wrapper #9065
Dist windows powershell wrapper #9065
Conversation
I'll fix that failure, likely tomorrow. Looks like the target folder for the template doesn't exist, because git doesn't pick it up thinking it's empty now that the only file that would be there is gitignored. I've got that folder locally, so my tests went through fine. I'll look into either adding a dummy file or making Rake create the folder structure. |
aa0dc87
to
9fce69f
Compare
The Rake job will now create the folder structure. This should be ready for review |
you should probably unsneak the chef-apply stuff since that can definitely go, the other stuff i have no idea about, but tim seems to have some concerns |
9fce69f
to
f61a516
Compare
@tas50 I understand you had worries about the approach I'm proposing? How can I make this awesome? |
Signed-off-by: Marc Chamberland <chamberland.marc@gmail.com>
Signed-off-by: Marc Chamberland <chamberland.marc@gmail.com>
f61a516
to
ba1f7c0
Compare
as discussed during triage, I added a commit to properly remove the original file prior to gitignoring it, |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
More work towards #8376 this one addresses the windows powershell extensions by templating the psm1 file and having Rake render it during builds. It also sneaks in a chef-apply distro constant for immediate use in the extensions.
Related Issue
#8376
Types of changes
Checklist: