Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dist windows powershell wrapper #9065

Merged
merged 2 commits into from Feb 25, 2020

Conversation

@bobchaos
Copy link
Contributor

bobchaos commented Nov 5, 2019

Description

More work towards #8376 this one addresses the windows powershell extensions by templating the psm1 file and having Rake render it during builds. It also sneaks in a chef-apply distro constant for immediate use in the extensions.

Related Issue

#8376

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • [NA] I have updated the documentation accordingly.
  • [NA] I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.
@bobchaos bobchaos requested review from chef/chef-infra-approvers as code owners Nov 5, 2019
@bobchaos bobchaos mentioned this pull request Nov 5, 2019
5 of 8 tasks complete
@bobchaos

This comment has been minimized.

Copy link
Contributor Author

bobchaos commented Nov 6, 2019

I'll fix that failure, likely tomorrow. Looks like the target folder for the template doesn't exist, because git doesn't pick it up thinking it's empty now that the only file that would be there is gitignored. I've got that folder locally, so my tests went through fine. I'll look into either adding a dummy file or making Rake create the folder structure.

@bobchaos bobchaos force-pushed the cinc-project:dist_windows_powershell_wrapper branch from aa0dc87 to 9fce69f Nov 6, 2019
@bobchaos

This comment has been minimized.

Copy link
Contributor Author

bobchaos commented Nov 6, 2019

The Rake job will now create the folder structure. This should be ready for review

@lamont-granquist

This comment has been minimized.

Copy link
Contributor

lamont-granquist commented Dec 9, 2019

you should probably unsneak the chef-apply stuff since that can definitely go, the other stuff i have no idea about, but tim seems to have some concerns

@bobchaos bobchaos force-pushed the cinc-project:dist_windows_powershell_wrapper branch from 9fce69f to f61a516 Dec 10, 2019
@bobchaos

This comment has been minimized.

Copy link
Contributor Author

bobchaos commented Dec 17, 2019

@tas50 I understand you had worries about the approach I'm proposing? How can I make this awesome?

bobchaos added 2 commits Feb 24, 2020
Signed-off-by: Marc Chamberland <chamberland.marc@gmail.com>
Signed-off-by: Marc Chamberland <chamberland.marc@gmail.com>
@cinc-bot cinc-bot force-pushed the cinc-project:dist_windows_powershell_wrapper branch from f61a516 to ba1f7c0 Feb 24, 2020
@bobchaos

This comment has been minimized.

Copy link
Contributor Author

bobchaos commented Feb 24, 2020

as discussed during triage, I added a commit to properly remove the original file prior to gitignoring it,

@tas50 tas50 merged commit 452b131 into chef:master Feb 25, 2020
2 of 3 checks passed
2 of 3 checks passed
buildkite/chef-chef-master-verify Build #2866 failed (20 minutes, 54 seconds)
Details
DCO This commit has a DCO Signed-off-by
Details
expeditor/config-validation Validated your Expeditor config file
Details
@bobchaos bobchaos mentioned this pull request Feb 27, 2020
5 of 8 tasks complete
@lock

This comment has been minimized.

Copy link

lock bot commented Mar 10, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.