Provide a method-based accessor for SimpleConfig hashes #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamleff
force-pushed
the
adamleff/hash-values-in-simpleconfig
branch
from
4f942f8
to
78a0190
Compare
chris-rock
reviewed
Mar 15, 2017
lib/utils/simpleconfig.rb
Outdated
| # (such as a mysql config that has [sections]), provide | ||
| # a hash whose values are accessible via methods to provide | ||
| # a good user experience with `its` blocks. | ||
| class ConfigHash < Hash |
There was a problem hiding this comment.
This is definitely a valid solution. We use hashie in other areas like https://github.com/chef/inspec/blob/546486ff6afc371103943501e9d7e15bcc6941ff/lib/resources/service.rb#L180-L183. Should we stick to the same solution?
There was a problem hiding this comment.
Hashie works for me too - updating now...
When SimpleConfig parses a config file that has sections, such as a mysqld
config file, the values within that section are returned via a Hash. However,
we do not provide an easy way to write tests for those deep hash values:
```
describe mysql_conf('/tmp/my.cnf') do
its('mysqld.expire_logs_days') { should cmp 10 }
end
MySQL Configuration
∅ undefined method `expire_logs_days' for #<Hash:0x007fe463795a00>
```
This change provides a method-based accessor for Hashes that are built via
SimpleConfig.
```
describe mysql_conf('/tmp/my.cnf') do
its('mysqld.expire_logs_days') { should cmp 10 }
end
MySQL Configuration
✔ mysqld.expire_logs_days should cmp == 10
```
Fixes #1541 by changing the way the attributes are fetched.
Signed-off-by: Adam Leff <adam@leff.co>
adamleff
force-pushed
the
adamleff/hash-values-in-simpleconfig
branch
from
78a0190
to
ea7c0c4
Compare
|
@chris-rock do you approve of this one now that I switched to using |
chris-rock
approved these changes
Mar 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SimpleConfig parses a config file that has sections, such as a mysqld
config file, the values within that section are returned via a Hash. However,
we do not provide an easy way to write tests for those deep hash values:
This change provides a method-based accessor for Hashes that are built via
SimpleConfig.
Fixes #1541 by changing the way the attributes are fetched.
Signed-off-by: Adam Leff adam@leff.co