postgres relative path includes #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postgres configuration doesnt always include absolute paths. When using relative paths it will fail! Also: We treat the include as either a string or an array; when the first condition succeeds and you get a string and the second fails you get a array => ruby tries to add a string with an array and fails. This is now fixed as well. Fixes: inspec#1780 Fixes: inspec#1738 Signed-off-by: Aaron Lippold <lippold@gmail.com>
arlimus
approved these changes
May 26, 2017
|
@arlimus You're very welcome :) lol |
|
Great meeting today |
|
Do we think that basedir should be a '@baseDir'? i.e. do we need to expose it? |
|
Not really; the base-dir is always based on the file that is currently being processed; since we are tackling relative files to the config file that is being loaded, it is only a snapshot in time ;) |
chris-rock
approved these changes
May 27, 2017
adamleff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgres configuration doesnt always include absolute paths. When using relative paths it will fail!
Also: We treat the include as either a string or an array; when the first condition succeeds and you get a string and the second fails you get a array => ruby tries to add a string with an array and fails. This is now fixed as well.
Fixes: #1780
Fixes: #1738
Signed-off-by: Aaron Lippold lippold@gmail.com